[asterisk-dev] [Code Review] Add global ao2 array container.

rmudgett reviewboard at asterisk.org
Wed Mar 21 16:37:26 CDT 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1824/
-----------------------------------------------------------

(Updated March 21, 2012, 4:37 p.m.)


Review request for Asterisk Developers and Matt Jordan.


Changes
-------

Addressed Mark Michelson's comments.  The unit test is more extensive and it still passes.


Summary
-------

Global ao2 objects must always exist after initialization because there is no access control to obtain another reference to the global object.

It is anticipated that the Asterisk 11 Configuration Management project could use these new API calls to replace an active configuration parameter object with an updated configuration parameter object.

With these new API calls, the global object could be replaced, removed, or referenced without the risk of someone using a stale global object pointer.


Diffs (updated)
-----

  /trunk/include/asterisk/astobj2.h 360189 
  /trunk/main/astobj2.c 360189 
  /trunk/tests/test_astobj2.c 360189 

Diff: https://reviewboard.asterisk.org/r/1824/diff


Testing
-------

Added a new unit test to exercise the new API calls.  They pass.


Thanks,

rmudgett

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120321/c3d5447a/attachment-0001.htm>


More information about the asterisk-dev mailing list