[asterisk-dev] [Code Review] avoid many cppcheck (#2)
wdoekes
reviewboard at asterisk.org
Fri Mar 16 03:01:02 CDT 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1743/#review5820
-----------------------------------------------------------
Ship it!
trunk/res/res_odbc.c
<https://reviewboard.asterisk.org/r/1743/#comment10664>
obj->con is already NULL.
Other than that. Good to go :)
- wdoekes
On March 14, 2012, 7:25 p.m., junky wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1743/
> -----------------------------------------------------------
>
> (Updated March 14, 2012, 7:25 p.m.)
>
>
> Review request for Asterisk Developers.
>
>
> Summary
> -------
>
> This patch is to prevent many more cppcheck warnings.
>
>
> Diffs
> -----
>
> trunk/apps/app_minivm.c 357660
> trunk/apps/app_osplookup.c 357660
> trunk/cdr/cdr_pgsql.c 357660
> trunk/cdr/cdr_sqlite3_custom.c 357660
> trunk/channels/chan_alsa.c 357660
> trunk/channels/chan_dahdi.c 357660
> trunk/channels/chan_gtalk.c 357660
> trunk/channels/chan_h323.c 357660
> trunk/channels/chan_sip.c 357660
> trunk/channels/chan_unistim.c 357660
> trunk/channels/vcodecs.c 357660
> trunk/codecs/codec_dahdi.c 357660
> trunk/codecs/codec_g726.c 357660
> trunk/codecs/codec_resample.c 357660
> trunk/formats/format_h264.c 357660
> trunk/funcs/func_callerid.c 357660
> trunk/funcs/func_devstate.c 357660
> trunk/funcs/func_env.c 357660
> trunk/funcs/func_groupcount.c 357660
> trunk/funcs/func_odbc.c 357660
> trunk/main/ast_expr2.fl 357660
> trunk/main/ast_expr2f.c 357660
> trunk/main/asterisk.c 357660
> trunk/main/data.c 357660
> trunk/res/res_config_ldap.c 357660
> trunk/res/res_config_sqlite3.c 357660
> trunk/res/res_corosync.c 357660
> trunk/res/res_format_attr_celt.c 357660
> trunk/res/res_format_attr_silk.c 357660
> trunk/res/res_http_post.c 357660
> trunk/res/res_jabber.c 357660
> trunk/res/res_musiconhold.c 357660
> trunk/res/res_odbc.c 357660
> trunk/res/res_phoneprov.c 357660
>
> Diff: https://reviewboard.asterisk.org/r/1743/diff
>
>
> Testing
> -------
>
> used cppcheck 1.52
> it compiles ;)
>
>
> Thanks,
>
> junky
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120316/7ba3c032/attachment.htm>
More information about the asterisk-dev
mailing list