[asterisk-dev] [Code Review] Test Queue(F)

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1789/#review5765
-----------------------------------------------------------



/asterisk/trunk/tests/queues/queue_transfer_callee/run-test
<https://reviewboard.asterisk.org/r/1789/#comment10553>

    Which I didn't really "write", so much as port over Matt Nicholson's lua test.  You don't need to give me credit for that :-)



/asterisk/trunk/tests/queues/queue_transfer_callee/run-test
<https://reviewboard.asterisk.org/r/1789/#comment10554>

    For the sake of consistency, we don't usually return -1 from failed tests, but 1.



/asterisk/trunk/tests/queues/queue_transfer_callee/test-config.yaml
<https://reviewboard.asterisk.org/r/1789/#comment10552>

    Don't put the version number in the description.  The minversion already specifies the version that is needed to run this test.



/asterisk/trunk/tests/queues/queue_transfer_callee/test-config.yaml
<https://reviewboard.asterisk.org/r/1789/#comment10556>

    I might be missing something here, but based on your description, the callee is a member of a queue, while the caller is the person who actually called the Queue application.  The description you have here states that the F option is triggered when the caller hangs up, i.e., the channel that actually entered the Queue application.  Based on that description, I would expect the test to have the channel that entered the Queue application hang up first, and then have the actions associated with the F option exercised on the channel that is a member of the queue.
    
    In your test, however, it appears as if the channel that hangs up first is not the channel that entered the Queue application, but rather the channel that enters test at test_context.  In that case, the description doesn't seem to match the test.



/asterisk/trunk/tests/queues/queue_transfer_callee/test-config.yaml
<https://reviewboard.asterisk.org/r/1789/#comment10555>

    Add tags here: at a minimum, you should have a tag of 'queues'


- Matt


On March 5, 2012, 2:02 p.m., jrose wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1789/
> -----------------------------------------------------------
> 
> (Updated March 5, 2012, 2:02 p.m.)
> 
> 
> Review request for Asterisk Developers, Mark Michelson, Paul Belanger, and Matt Jordan.
> 
> 
> Summary
> -------
> 
> Adds a test for new Queue Option F.
> 
> This is basically just like the Baseline Queue Test, only there are 4 scenarios tested and they all use QueueF with different arguments.
> 
> 
> This addresses bug ASTERISK-19283.
>     https://issues.asterisk.org/jira/browse/ASTERISK-19283
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/queues/queue_transfer_callee/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/queues/queue_transfer_callee/configs/ast1/queues.conf PRE-CREATION 
>   /asterisk/trunk/tests/queues/queue_transfer_callee/run-test PRE-CREATION 
>   /asterisk/trunk/tests/queues/queue_transfer_callee/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/queues/tests.yaml 3072 
> 
> Diff: https://reviewboard.asterisk.org/r/1789/diff
> 
> 
> Testing
> -------
> 
> It's a test.  I ran it a number of times, checked log messages, etc.  Nothing too special.
> 
> 
> Thanks,
> 
> jrose
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120308/b6659e9b/attachment.htm>