[asterisk-dev] [Code Review]: Update to review 1160

[Terry Wilson]

> On March 7, 2012, 1:18 p.m., Tilghman Lesher wrote:
> > /trunk/cel/cel_odbc.c, lines 488-493
> > <https://reviewboard.asterisk.org/r/1804/diff/1/?file=25875#file25875line488>
> >
> >     Not so fast.  This breaks the specification of "static" values in the configuration file.  In this case, celname is going to be blank.

There is a check for staticvalue before we ever get here. There is no way for unknown to be set if staticvalue is set.


> On March 7, 2012, 1:18 p.m., Tilghman Lesher wrote:
> > /trunk/cel/cel_odbc.c, lines 446-448
> > <https://reviewboard.asterisk.org/r/1804/diff/1/?file=25875#file25875line446>
> >
> >     Stylistically, this should be specified as a final "else if", to reduce the number of changed lines.

If it makes you happy for it to be at the end, it's at the end.


- Terry


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1804/#review5755
-----------------------------------------------------------


On March 7, 2012, 7:24 a.m., Terry Wilson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1804/
> -----------------------------------------------------------
> 
> (Updated March 7, 2012, 7:24 a.m.)
> 
> 
> Review request for Asterisk Developers and Tilghman Lesher.
> 
> 
> Summary
> -------
> 
> This basically just addresses tilghman's last comment on review 1160 since that review stalled. It also adds a check for columns that that we don't know about, so that if we are doing an INSERT, we don't complain about empty values for columns like auto-incremented ids, etc.
> 
> The checks for wide characters should probably be backported to 1.8+ since recent mysql odbc connectors throw a bunch of warnings becauase the varchar types end up being used.
> 
> 
> This addresses bug ASTERISK-17548.
>     https://issues.asterisk.org/jira/browse/ASTERISK-17548
> 
> 
> Diffs
> -----
> 
>   /trunk/cel/cel_odbc.c 358426 
>   /trunk/configs/cel_odbc.conf.sample 358426 
> 
> Diff: https://reviewboard.asterisk.org/r/1804/diff
> 
> 
> Testing
> -------
> 
> Installed odbc stuff and mysql/postgres and set up CEL. I didn't see any problems.
> 
> 
> Thanks,
> 
> Terry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120307/d722ac56/attachment.htm>