[asterisk-dev] [Code Review] Fix DNS resolution for IPv4 when UDP transport is IPv6 only.

[opticron]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1667/#review5722
-----------------------------------------------------------

Ship it!


This doesn't apply cleanly to the latest branches any more (dnsmgr changes close to modified code), but all the changes look good.

- opticron


On Jan. 11, 2012, 10:38 a.m., Joshua Colp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1667/
> -----------------------------------------------------------
> 
> (Updated Jan. 11, 2012, 10:38 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This changes the address family filtering when doing DNS resolution to take the transport type into account. By taking the transport type into account the correct bound address can be used to return the proper address family. Previously the UDP address was always used so if it were set to IPv6 only then IPv4 resolution was not possible on the TCP or TLS transport.
> 
> 
> Diffs
> -----
> 
>   /branches/1.8/channels/chan_sip.c 350362 
> 
> Diff: https://reviewboard.asterisk.org/r/1667/diff
> 
> 
> Testing
> -------
> 
> Confirmed registrations and calls are now possible when UDP transport is IPv6 only and TCP/TLS transport is IPv4 only.
> 
> 
> Thanks,
> 
> Joshua
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120302/2a3bf7f3/attachment.htm>