[asterisk-dev] [Code Review] Triggers dialplan actions when specific CONTROL_FRAMES are detected on a channel

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1778/#review5681
-----------------------------------------------------------



/trunk/funcs/func_frame_trigger.c
<https://reviewboard.asterisk.org/r/1778/#comment10383>

    Use an enum so that things are more clear.



/trunk/funcs/func_frame_trigger.c
<https://reviewboard.asterisk.org/r/1778/#comment10385>

    This second line starts waaaaaay too far from the left edge.



/trunk/funcs/func_frame_trigger.c
<https://reviewboard.asterisk.org/r/1778/#comment10384>

    Two things:
    
    1. We don't use camelCase for function names in Asterisk.
    2. What is "sintesize?"



/trunk/funcs/func_frame_trigger.c
<https://reviewboard.asterisk.org/r/1778/#comment10386>

    No camelCase please.



/trunk/funcs/func_frame_trigger.c
<https://reviewboard.asterisk.org/r/1778/#comment10387>

    This is not necessary because ast_calloc will zero out framedata->triggergosub.



/trunk/funcs/func_frame_trigger.c
<https://reviewboard.asterisk.org/r/1778/#comment10388>

    Add curly braces.



/trunk/funcs/func_frame_trigger.c
<https://reviewboard.asterisk.org/r/1778/#comment10436>

    No camelCase



/trunk/funcs/func_frame_trigger.c
<https://reviewboard.asterisk.org/r/1778/#comment10434>

    Curly braces please.



/trunk/funcs/func_frame_trigger.c
<https://reviewboard.asterisk.org/r/1778/#comment10435>

    Curly braces please.


- Mark


On Feb. 29, 2012, 10:02 a.m., Marco Signorini wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1778/
> -----------------------------------------------------------
> 
> (Updated Feb. 29, 2012, 10:02 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> A filter can be applied to the trigger to limit frames sensibility. This filter can either be a white or black list of control frame types. When no filter type is present, white is used. If no arguments are provided at all, all frames will trigger the specified gosub call.
> If the specified gosub extension is not present on the dialplan, the function will gosub to the "s-XXXX" extension in the gosub context where XXXX is the type of the control frame.
> It can be set only once on a given channel.
> 
> Examples:
> exten => 1,1,Set(FRAME_TRIGGER(white, CONTROL_HOLD)=ext,context); trigger gosub ext-CONTROL_HOLD at context only for HOLD type control frames
> exten => 1,1,Set(FRAME_TRIGGER(black, CONTROL_HOLD)=ext,context); trigger gosub ext-CONTROL_XXXX at context for all control type frames except for HOLD type control frames
> exten => 1,1,Set(FRAME_TRIGGER(CONTROL_HOLD, CONTROL_UNHOLD)=context) ; trigger gosub to s-CONTROL_HOLD at context and s-CONTROL_UNHOLD context only for HOLD and UNHOLD type control frames
> 
> This feature was originally developed in order to track MOH events in a call center environment but has general interest.
> 
> 
> This addresses bug ASTERISK-19319.
>     https://issues.asterisk.org/jira/browse/ASTERISK-19319
> 
> 
> Diffs
> -----
> 
>   /trunk/funcs/func_frame_trigger.c PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/1778/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120301/676a824f/attachment-0001.htm>