[asterisk-dev] [Code Review] SDP Media Attribute Interface + H.263/H.264 Format Attribute Modules

[Joshua Colp]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2005/
-----------------------------------------------------------

Review request for Asterisk Developers.


Summary
-------

This patch adds to the format attribute interface two methods used to parse and generate SDP for formats. It also adds two format attribute modules - one for H.263 and one for H.264. The SDP logic for CELT and SILK have also been moved to their respective format attribute modules.


Diffs
-----

  /trunk/channels/chan_sip.c 368849 
  /trunk/include/asterisk/format.h 368849 
  /trunk/main/format.c 368849 
  /trunk/main/translate.c 368849 
  /trunk/res/res_format_attr_celt.c 368849 
  /trunk/res/res_format_attr_h263.c PRE-CREATION 
  /trunk/res/res_format_attr_h264.c PRE-CREATION 
  /trunk/res/res_format_attr_silk.c 368849 

Diff: https://reviewboard.asterisk.org/r/2005/diff


Testing
-------

Performed heavy testing of H.263 and H.264 format attribute modules using various softphones and different scenarios.


Thanks,

Joshua

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120627/fafda1b4/attachment-0001.htm>