[asterisk-dev] [Code Review]: logger: Call ID logging phase III part 1 split - chan_iax2 and chan_dahdi

[jrose]

> On June 26, 2012, 3:34 p.m., rmudgett wrote:
> > /trunk/main/logger.c, line 1786
> > <https://reviewboard.asterisk.org/r/1927/diff/10-11/?file=29176#file29176line1786>
> >
> >     Replace NULL with callid.

check


- jrose


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1927/#review6577
-----------------------------------------------------------


On June 26, 2012, 2:02 p.m., jrose wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1927/
> -----------------------------------------------------------
> 
> (Updated June 26, 2012, 2:02 p.m.)
> 
> 
> Review request for Asterisk Developers, rmudgett and Matt Jordan.
> 
> 
> Summary
> -------
> 
> split from: https://reviewboard.asterisk.org/r/1886/
> These changes allow channels dahdi and iax2 to set callids and bind log messages to callids.
> 
> This is the same code as in the earlier review.  It was split to commit the approved parts and to hopefully encourage some review of the remaining parts since there is less in here to review now.
> 
> 
> Diffs
> -----
> 
>   /trunk/channels/chan_agent.c 369392 
>   /trunk/channels/chan_dahdi.c 369392 
>   /trunk/channels/chan_iax2.c 369392 
>   /trunk/channels/chan_local.c 369392 
>   /trunk/channels/sig_analog.c 369392 
>   /trunk/channels/sig_pri.c 369392 
>   /trunk/channels/sig_ss7.c 369392 
>   /trunk/include/asterisk/logger.h 369392 
>   /trunk/main/autoservice.c 369392 
>   /trunk/main/bridging.c 369392 
>   /trunk/main/channel_internal_api.c 369392 
>   /trunk/main/cli.c 369392 
>   /trunk/main/features.c 369392 
>   /trunk/main/logger.c 369392 
>   /trunk/main/pbx.c 369392 
> 
> Diff: https://reviewboard.asterisk.org/r/1927/diff
> 
> 
> Testing
> -------
> 
> see https://reviewboard.asterisk.org/r/1886/
> 
> 
> Thanks,
> 
> jrose
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120626/dda025fa/attachment-0001.htm>