[asterisk-dev] [Code Review] logger: Call ID logging phase III part 1 split - chan_iax2 and chan_dahdi

rmudgett reviewboard at asterisk.org
Tue Jun 26 13:24:38 CDT 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1927/#review6572
-----------------------------------------------------------



/trunk/channels/chan_iax2.c
<https://reviewboard.asterisk.org/r/1927/#comment12467>

    This magic number needs a define.  You are using this magic number in several places.
    Here and in channel_internal_api.c, and cli.c.



/trunk/channels/sig_analog.c
<https://reviewboard.asterisk.org/r/1927/#comment12471>

    This doesn't need to be initialized.



/trunk/channels/sig_analog.c
<https://reviewboard.asterisk.org/r/1927/#comment12472>

    Need a callid autoclean here.



/trunk/channels/sig_ss7.c
<https://reviewboard.asterisk.org/r/1927/#comment12470>

    The private is also already obtained.
    Also this is ss7 not pri.
    
     * \note Assumes the ss7->lock is already obtained.
     * \note Assumes the sig_ss7_lock_private(ss7->pvts[chanpos]) is already obtained.
    



/trunk/main/logger.c
<https://reviewboard.asterisk.org/r/1927/#comment12473>

    Revert this.  I don't think this message is useful.  The callid could be NULL if the earlier call to ast_callid_threadstorage_auto() failed.



/trunk/main/logger.c
<https://reviewboard.asterisk.org/r/1927/#comment12474>

    You need to do the same thing here as was done to __ast_verbose().


- rmudgett


On June 26, 2012, 11:31 a.m., jrose wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1927/
> -----------------------------------------------------------
> 
> (Updated June 26, 2012, 11:31 a.m.)
> 
> 
> Review request for Asterisk Developers, rmudgett and Matt Jordan.
> 
> 
> Summary
> -------
> 
> split from: https://reviewboard.asterisk.org/r/1886/
> These changes allow channels dahdi and iax2 to set callids and bind log messages to callids.
> 
> This is the same code as in the earlier review.  It was split to commit the approved parts and to hopefully encourage some review of the remaining parts since there is less in here to review now.
> 
> 
> Diffs
> -----
> 
>   /trunk/channels/chan_agent.c 369392 
>   /trunk/channels/chan_dahdi.c 369392 
>   /trunk/channels/chan_iax2.c 369392 
>   /trunk/channels/chan_local.c 369392 
>   /trunk/channels/sig_analog.c 369392 
>   /trunk/channels/sig_pri.c 369392 
>   /trunk/channels/sig_ss7.c 369392 
>   /trunk/include/asterisk/logger.h 369392 
>   /trunk/main/autoservice.c 369392 
>   /trunk/main/bridging.c 369392 
>   /trunk/main/features.c 369392 
>   /trunk/main/logger.c 369392 
>   /trunk/main/pbx.c 369392 
> 
> Diff: https://reviewboard.asterisk.org/r/1927/diff
> 
> 
> Testing
> -------
> 
> see https://reviewboard.asterisk.org/r/1886/
> 
> 
> Thanks,
> 
> jrose
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120626/e3a746ae/attachment-0001.htm>


More information about the asterisk-dev mailing list