[asterisk-dev] [Code Review]: logger: Call ID logging phase III part 1 split - chan_iax2 and chan_dahdi

[rmudgett]

> On June 25, 2012, 1:19 p.m., rmudgett wrote:
> > /trunk/include/asterisk/logger.h, line 111
> > <https://reviewboard.asterisk.org/r/1927/diff/8/?file=29125#file29125line111>
> >
> >     I think this can be deleted since nobody uses it.
> 
> jrose wrote:
>     I don't see any reason to delete that as part of this patch regardless.  Besides, some random person might be using it in local modifications or something.

The reason I pointed this out is because you changed the API.  Any users of the macro would get a compile error.  Since there does not appear to be any users, it could be deleted.


- rmudgett


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1927/#review6564
-----------------------------------------------------------


On June 26, 2012, 10:29 a.m., jrose wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1927/
> -----------------------------------------------------------
> 
> (Updated June 26, 2012, 10:29 a.m.)
> 
> 
> Review request for Asterisk Developers, rmudgett and Matt Jordan.
> 
> 
> Summary
> -------
> 
> split from: https://reviewboard.asterisk.org/r/1886/
> These changes allow channels dahdi and iax2 to set callids and bind log messages to callids.
> 
> This is the same code as in the earlier review.  It was split to commit the approved parts and to hopefully encourage some review of the remaining parts since there is less in here to review now.
> 
> 
> Diffs
> -----
> 
>   /trunk/channels/chan_agent.c 369392 
>   /trunk/channels/chan_dahdi.c 369392 
>   /trunk/channels/chan_iax2.c 369392 
>   /trunk/channels/chan_local.c 369392 
>   /trunk/channels/sig_analog.c 369392 
>   /trunk/channels/sig_pri.c 369392 
>   /trunk/channels/sig_ss7.c 369392 
>   /trunk/include/asterisk/logger.h 369392 
>   /trunk/main/autoservice.c 369392 
>   /trunk/main/bridging.c 369392 
>   /trunk/main/features.c 369392 
>   /trunk/main/logger.c 369392 
>   /trunk/main/pbx.c 369392 
> 
> Diff: https://reviewboard.asterisk.org/r/1927/diff
> 
> 
> Testing
> -------
> 
> see https://reviewboard.asterisk.org/r/1886/
> 
> 
> Thanks,
> 
> jrose
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120626/81751929/attachment.htm>