[asterisk-dev] [Code Review] Correct message array allocation issues in app_voicemail

[opticron]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1994/
-----------------------------------------------------------

(Updated June 25, 2012, 3:56 p.m.)


Review request for Asterisk Developers.


Changes
-------

Add locking around dh_arraysize accesses as well as heard and deleted arrays.


Summary
-------

This patch reworks the handling of array allocation and freeing to ensure that freed memory is not used.


This addresses bug AST-894.
    https://issues.asterisk.org/jira/browse/AST-894


Diffs (updated)
-----

  branches/1.8/apps/app_voicemail.c 368758 

Diff: https://reviewboard.asterisk.org/r/1994/diff


Testing
-------

Poked through voicemail manually.  Testing has been performed on issue ASTERISK-19923 and seems to have corrected the segfault in that case.


Thanks,

opticron

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120625/b79afbef/attachment.htm>