[asterisk-dev] [Code Review] Correct message array allocation issues in app_voicemail

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1994/#review6553
-----------------------------------------------------------



branches/1.8/apps/app_voicemail.c
<https://reviewboard.asterisk.org/r/1994/#comment12368>

    There's an access to vms->dh_arraysize here without a lock held.


- Mark


On June 20, 2012, 3:18 p.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1994/
> -----------------------------------------------------------
> 
> (Updated June 20, 2012, 3:18 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This patch reworks the handling of array allocation and freeing to ensure that freed memory is not used.
> 
> 
> This addresses bug AST-894.
>     https://issues.asterisk.org/jira/browse/AST-894
> 
> 
> Diffs
> -----
> 
>   branches/1.8/apps/app_voicemail.c 368806 
> 
> Diff: https://reviewboard.asterisk.org/r/1994/diff
> 
> 
> Testing
> -------
> 
> Poked through voicemail manually.  Testing has been performed on issue ASTERISK-19923 and seems to have corrected the segfault in that case.
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120622/38fd7f39/attachment.htm>