[asterisk-dev] [Code Review]: Add cause reporting to sig_ss7 for chan_dahdi

[opticron]

> On June 21, 2012, 11:51 a.m., rmudgett wrote:
> > trunk/channels/sig_ss7.c, lines 388-390
> > <https://reviewboard.asterisk.org/r/1955/diff/2/?file=29087#file29087line388>
> >
> >     Change to an owner pointer since that is all you are using p for.  In fact why not just pass the owner into the function?

Made it so only owner is passed in.


> On June 21, 2012, 11:51 a.m., rmudgett wrote:
> > trunk/channels/sig_ss7.c, line 1083
> > <https://reviewboard.asterisk.org/r/1955/diff/2/?file=29087#file29087line1083>
> >
> >     No need to initialize.

Fixed.


> On June 21, 2012, 11:51 a.m., rmudgett wrote:
> > trunk/channels/sig_ss7.c, line 1300
> > <https://reviewboard.asterisk.org/r/1955/diff/2/?file=29087#file29087line1300>
> >
> >     Lock the owner before testing like the other examples of sig_ss7_lock_owner().

Fixed.


> On June 21, 2012, 11:51 a.m., rmudgett wrote:
> > trunk/channels/sig_ss7.c, line 1301
> > <https://reviewboard.asterisk.org/r/1955/diff/2/?file=29087#file29087line1301>
> >
> >     This might not be dimensioned large enough.

Actually, it's too big.  Dropped to 30.


- opticron


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1955/#review6533
-----------------------------------------------------------


On June 21, 2012, 9:39 a.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1955/
> -----------------------------------------------------------
> 
> (Updated June 21, 2012, 9:39 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This adds HANGUPCAUSE hash reporting to the SS7 technology for chan_dahdi.
> 
> 
> This addresses bug SWP-4222.
>     https://issues.asterisk.org/jira/browse/SWP-4222
> 
> 
> Diffs
> -----
> 
>   trunk/channels/sig_ss7.c 369180 
> 
> Diff: https://reviewboard.asterisk.org/r/1955/diff
> 
> 
> Testing
> -------
> 
> Tested with a SS7 link connected between two machines.
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120621/8743c9a2/attachment.htm>