[asterisk-dev] [Code Review] logger: Call ID logging phase III part 1 split - chan_iax2 and chan_dahdi

jrose reviewboard at asterisk.org
Thu Jun 21 14:41:45 CDT 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1927/
-----------------------------------------------------------

(Updated June 21, 2012, 2:41 p.m.)


Review request for Asterisk Developers, rmudgett and Matt Jordan.


Changes
-------

Adds the ast_log -> ast_log_callid changes Richard mentioned in the above review

Also adds functions/macros for ast_verbose_callid and ast_verb_callid, which have all been tested.

Adds the ast_verbose -> ast_verboe_callid changes Richard mentioned in the above review.


Summary
-------

split from: https://reviewboard.asterisk.org/r/1886/
These changes allow channels dahdi and iax2 to set callids and bind log messages to callids.

This is the same code as in the earlier review.  It was split to commit the approved parts and to hopefully encourage some review of the remaining parts since there is less in here to review now.


Diffs (updated)
-----

  /trunk/channels/chan_agent.c 369042 
  /trunk/channels/chan_dahdi.c 369042 
  /trunk/channels/chan_iax2.c 369042 
  /trunk/channels/chan_local.c 369042 
  /trunk/channels/sig_analog.c 369042 
  /trunk/channels/sig_pri.c 369042 
  /trunk/channels/sig_ss7.c 369042 
  /trunk/include/asterisk/logger.h 369042 
  /trunk/main/autoservice.c 369042 
  /trunk/main/bridging.c 369042 
  /trunk/main/logger.c 369042 
  /trunk/main/pbx.c 369042 

Diff: https://reviewboard.asterisk.org/r/1927/diff


Testing
-------

see https://reviewboard.asterisk.org/r/1886/


Thanks,

jrose

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120621/ab28475e/attachment.htm>


More information about the asterisk-dev mailing list