[asterisk-dev] [Code Review]: logger: Call ID logging phase III part 1 split - chan_iax2 and chan_dahdi

rmudgett reviewboard at asterisk.org
Thu Jun 21 12:02:29 CDT 2012



> On June 20, 2012, 4:56 p.m., rmudgett wrote:
> > /trunk/channels/chan_dahdi.c, line 14304
> > <https://reviewboard.asterisk.org/r/1927/diff/4/?file=28956#file28956line14304>
> >
> >     In this function change the logging functions to explicit callid versions.  We don't need to see the callid information in the PRI debug logging output.
> >     
> >     For this function it is ast_log_callid and pass NULL for the callid.
> 
> jrose wrote:
>     I don't really see why we wouldn't want to have the callid information for these log messages.  If the thread is bound to a call id when it shouldn't be, that's a problem... but if we bound a thread to a call id for a legitimate reason when these functions were called, that generally means they are associated with a call of some kind.  Could you explain?

These are the D channel decode output functions from libpri and SS7 signaling decode output functions from libss7.  They cannot be tagged with a callid. This is lower layer activity.  The lower layer does not correlate with a callid.


- rmudgett


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1927/#review6517
-----------------------------------------------------------


On June 21, 2012, 9:50 a.m., jrose wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1927/
> -----------------------------------------------------------
> 
> (Updated June 21, 2012, 9:50 a.m.)
> 
> 
> Review request for Asterisk Developers, rmudgett and Matt Jordan.
> 
> 
> Summary
> -------
> 
> split from: https://reviewboard.asterisk.org/r/1886/
> These changes allow channels dahdi and iax2 to set callids and bind log messages to callids.
> 
> This is the same code as in the earlier review.  It was split to commit the approved parts and to hopefully encourage some review of the remaining parts since there is less in here to review now.
> 
> 
> Diffs
> -----
> 
>   /trunk/channels/chan_agent.c 369042 
>   /trunk/channels/chan_dahdi.c 369042 
>   /trunk/channels/chan_iax2.c 369042 
>   /trunk/channels/chan_local.c 369042 
>   /trunk/channels/sig_analog.c 369042 
>   /trunk/channels/sig_pri.c 369042 
>   /trunk/channels/sig_ss7.c 369042 
>   /trunk/main/autoservice.c 369042 
>   /trunk/main/bridging.c 369042 
>   /trunk/main/logger.c 369042 
>   /trunk/main/pbx.c 369042 
> 
> Diff: https://reviewboard.asterisk.org/r/1927/diff
> 
> 
> Testing
> -------
> 
> see https://reviewboard.asterisk.org/r/1886/
> 
> 
> Thanks,
> 
> jrose
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120621/9639920d/attachment.htm>


More information about the asterisk-dev mailing list