[asterisk-dev] [Code Review]: Add cause reporting to sig_ss7 for chan_dahdi

[opticron]

> On June 21, 2012, 8:39 a.m., Matt Jordan wrote:
> > trunk/channels/sig_ss7.c, line 395
> > <https://reviewboard.asterisk.org/r/1955/diff/1/?file=28414#file28414line395>
> >
> >     In two of the three calls to this function, the owning channel is already locked.
> >     
> >     Why not just require that both the pvt and the owner be locked, and lock the owner before the call on line 1312?

Good catch, done.


- opticron


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1955/#review6521
-----------------------------------------------------------


On May 31, 2012, 1:38 p.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1955/
> -----------------------------------------------------------
> 
> (Updated May 31, 2012, 1:38 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This adds HANGUPCAUSE hash reporting to the SS7 technology for chan_dahdi.
> 
> 
> This addresses bug SWP-4222.
>     https://issues.asterisk.org/jira/browse/SWP-4222
> 
> 
> Diffs
> -----
> 
>   trunk/channels/sig_ss7.c 367780 
> 
> Diff: https://reviewboard.asterisk.org/r/1955/diff
> 
> 
> Testing
> -------
> 
> Tested with a SS7 link connected between two machines.
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120621/8c29010d/attachment-0001.htm>