[asterisk-dev] [Code Review] Dialplan function for manager account checks - AMI_CLIENT()

Terry Wilson reviewboard at asterisk.org
Thu Jun 14 14:31:59 CDT 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/421/#review6468
-----------------------------------------------------------

Ship it!


Looks like it still applies cleanly to trunk. With the minor documentation change, I say ship It.


/trunk/main/manager.c
<https://reviewboard.asterisk.org/r/421/#comment12212>

    I think a good way to document this would be like I did in res_calendar:
    
    <parameter name="field" required="true">
        <enumlist>
            <enum name="sessions"><para>The number of sessions for this AMI account</para></enum>
        </enumlist>
    </parameter>


- Terry


On Oct. 31, 2011, 10:32 a.m., Olle E Johansson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/421/
> -----------------------------------------------------------
> 
> (Updated Oct. 31, 2011, 10:32 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Implementation of a dialplan function for checking manager accounts. I've made it extensible so that we can add other parameters when needed. Right now it only checks the number of logged in sessions for a manager account.
> 
> 
> Diffs
> -----
> 
>   /trunk/main/manager.c 342755 
> 
> Diff: https://reviewboard.asterisk.org/r/421/diff
> 
> 
> Testing
> -------
> 
> Tested on my Linux system and it reports manager logins properly - 0, 1 and 2 concurrent sessions...
> 
> 
> Thanks,
> 
> Olle E
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120614/aa3096ef/attachment.htm>


More information about the asterisk-dev mailing list