[asterisk-dev] [Code Review] Allow chan_sip to decline unwanted media streams

[Joshua Colp]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1988/#review6460
-----------------------------------------------------------

Ship it!



trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/1988/#comment12204>

    Nitpick: Use *offer instead of struct offered_media.


- Joshua


On June 13, 2012, 1:15 p.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1988/
> -----------------------------------------------------------
> 
> (Updated June 13, 2012, 1:15 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This modification stores known SDP streams in an AST_LIST in the sip pvt, replacing the static offered_media array so that port-zeroed version of each stream can be stored and used when rebuilding the SDP response.  This also makes messages and comments more consistent.  This is targeted toward trunk and Asterisk 11.
> 
> 
> Diffs
> -----
> 
>   trunk/channels/chan_sip.c 368849 
>   trunk/channels/sip/include/sip.h 368849 
> 
> Diff: https://reviewboard.asterisk.org/r/1988/diff
> 
> 
> Testing
> -------
> 
> Ran this through the testsuite and the only thing that failed was SDP_offer_answer (which was expected).
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120614/ea2df8fa/attachment.htm>