[asterisk-dev] [Code Review] Allow chan_sip to decline unwanted media streams

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1988/#review6450
-----------------------------------------------------------


This seems like a fairly intrusive change for a release branch.  If we're going to make this change, then the SDP_offer_answer test should be passing with no modifications to the test.

If its failing because Asterisk no longer rejects offers in the same fashion, then I'm not sure we should make this change in a release branch.


trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/1988/#comment12189>

    I'm not sure we should be building decline information every time we have an offer.  I would expect that we would only build decline information for an offer if Asterisk can't handle that offer.
    
    This finding applies to the other media types as well.



trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/1988/#comment12190>

    I'm not a fan of comments directly in a malloc statement.



trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/1988/#comment12188>

    This is a pretty large change in behavior for a release branch.  I'd prefer to keep the existing behavior, i.e., if Asterisk is offered audio that it can't understand, the entire offer is rejected.
    
    This finding applies to the other media types as well.


- Matt


On June 12, 2012, 9:56 p.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1988/
> -----------------------------------------------------------
> 
> (Updated June 12, 2012, 9:56 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This modification stores known SDP streams in an AST_LIST in the sip pvt, replacing the static offered_media array so that port-zeroed version of each stream can be stored and used when rebuilding the SDP response.  This also makes messages and comments more consistent.
> 
> 
> Diffs
> -----
> 
>   trunk/channels/chan_sip.c 368849 
>   trunk/channels/sip/include/sip.h 368849 
> 
> Diff: https://reviewboard.asterisk.org/r/1988/diff
> 
> 
> Testing
> -------
> 
> Ran this through the testsuite and the only thing that failed was SDP_offer_answer (which was expected).
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120613/e2724cfc/attachment-0001.htm>