[asterisk-dev] [Code Review] Add the ability to support filename aliases for the Config Options API

[Joshua Colp]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1981/#review6431
-----------------------------------------------------------

Ship it!


You did what I wanted! I was thinking you might forget and use the current filename in the log messages but nope, you use the preferred one. Yay.

- Joshua


On June 7, 2012, 9:03 p.m., Terry Wilson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1981/
> -----------------------------------------------------------
> 
> (Updated June 7, 2012, 9:03 p.m.)
> 
> 
> Review request for Asterisk Developers and Joshua Colp.
> 
> 
> Summary
> -------
> 
> In the case where a config file has been renamed between releases, but we still want to support the old filename, it is important to be able to have a filename alias. This patch adds a single filename alias field (hopefully we don't have to support an actual array of aliases) and then uses the magic of the goto statement to make sure it is checked if we don't find the canonical filename.
> 
> 
> Diffs
> -----
> 
>   /trunk/main/config_options.c 368687 
>   /trunk/include/asterisk/config_options.h 368687 
> 
> Diff: https://reviewboard.asterisk.org/r/1981/diff
> 
> 
> Testing
> -------
> 
> Tried with and without alias filenames, with and without the canonical file existing. Things worked.
> 
> 
> Thanks,
> 
> Terry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120611/967e4d67/attachment.htm>