[asterisk-dev] [Code Review] Add post_apply callback for config options api

Joshua Colp reviewboard at asterisk.org
Mon Jun 11 06:57:10 CDT 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1980/#review6430
-----------------------------------------------------------

Ship it!


- Joshua


On June 7, 2012, 5:31 p.m., Terry Wilson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1980/
> -----------------------------------------------------------
> 
> (Updated June 7, 2012, 5:31 p.m.)
> 
> 
> Review request for Asterisk Developers and jrose.
> 
> 
> Summary
> -------
> 
> While it is possible to check that aco_process_config(...) == ACO_PROCESS_OK everywhere you call it and then insert some code to execute to do post processing, it is easier to just be able to register a callback function that only fires when changes are applied.
> 
> 
> Diffs
> -----
> 
>   /trunk/main/config_options.c 368673 
>   /trunk/include/asterisk/config_options.h 368673 
> 
> Diff: https://reviewboard.asterisk.org/r/1980/diff
> 
> 
> Testing
> -------
> 
> Used it. It worked.
> 
> 
> Thanks,
> 
> Terry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120611/2f2ae94e/attachment.htm>


More information about the asterisk-dev mailing list