[asterisk-dev] Unsubscribe

Sun Jun 10 09:47:05 CDT 2012

Sent from BlackBerry® on Airtel

-----Original Message-----
From: asterisk-dev-request at lists.digium.com
Sender: asterisk-dev-bounces at lists.digium.com
Date: Sun, 10 Jun 2012 08:31:27 
To: <asterisk-dev at lists.digium.com>
Reply-To: asterisk-dev at lists.digium.com
Subject:  asterisk-dev Digest, Vol 95, Issue 42
Send asterisk-dev mailing list submissions to
	asterisk-dev at lists.digium.com

To subscribe or unsubscribe via the World Wide Web, visit
	http://lists.digium.com/mailman/listinfo/asterisk-dev
or, via email, send a message with subject or body 'help' to
	asterisk-dev-request at lists.digium.com

You can reach the person managing the list at
	asterisk-dev-owner at lists.digium.com

When replying, please edit your Subject line so it is more specific
than "Re: Contents of asterisk-dev digest..."

Today's Topics:

   1. Unsubscribe (Vinod Dharashive @ AltruistIndia)
   2. Re: [Code Review] Add AMI event documentation (Russell Bryant)

----------------------------------------------------------------------

Message: 1
Date: Sat, 9 Jun 2012 16:51:42 +0000
From: "Vinod Dharashive @ AltruistIndia"
	<vinod.dharashive at altruistindia.com>
Subject: [asterisk-dev] Unsubscribe
To: asterisk-dev at lists.digium.com
Message-ID:
	<1974755730-1339260704-cardhu_decombobulator_blackberry.rim.net-1338164226- at b3.c19.bise7.blackberry>

Content-Type: text/plain; charset="Windows-1252"

Sent from BlackBerry? on Airtel

-----Original Message-----
From: asterisk-dev-request at lists.digium.com
Sender: asterisk-dev-bounces at lists.digium.com
Date: Sat, 09 Jun 2012 12:00:02 
To: <asterisk-dev at lists.digium.com>
Reply-To: asterisk-dev at lists.digium.com
Subject:  asterisk-dev Digest, Vol 95, Issue 41
Send asterisk-dev mailing list submissions to
	asterisk-dev at lists.digium.com

To subscribe or unsubscribe via the World Wide Web, visit
	http://lists.digium.com/mailman/listinfo/asterisk-dev
or, via email, send a message with subject or body 'help' to
	asterisk-dev-request at lists.digium.com

You can reach the person managing the list at
	asterisk-dev-owner at lists.digium.com

When replying, please edit your Subject line so it is more specific
than "Re: Contents of asterisk-dev digest..."

Today's Topics:

   1. Re: [Code Review]: named_acls: Named ACLs - a system for
      creating and applying ACLs with named profiles which can be
      shared (Kevin Fleming)

----------------------------------------------------------------------

Message: 1
Date: Sat, 09 Jun 2012 13:07:52 -0000
From: "Kevin Fleming" <reviewboard at asterisk.org>
Subject: Re: [asterisk-dev] [Code Review]: named_acls: Named ACLs - a
	system for creating and applying ACLs with named profiles which can be
	shared
To: "Olle E Johansson" <oej at edvina.net>, "Terry Wilson"
	<twilson at digium.com>, 	"Mark Michelson" <mmichelson at digium.com>
Cc: , Kevin Fleming <reviewboard at asterisk.org>,	Asterisk Developers
	<asterisk-dev at lists.digium.com>,	Kevin Fleming <kpfleming at digium.com>
Message-ID: <20120609130752.31443.54813 at hotblack.digium.com>
Content-Type: text/plain; charset="utf-8"

> On June 7, 2012, 1:10 p.m., jcolp wrote:
> > /trunk/main/named_acl.c, line 8
> > <https://reviewboard.asterisk.org/r/1978/diff/1/?file=28618#file28618line8>
> >
> >     Pfft! Wilson not wilson.
> 
> jrose wrote:
>     fixed

This entire file header needs to be replaced with something much closer to our standard file header. We don't provide attribution to people who wrote other parts of Asterisk in a file that uses them, and we don't put file version numbers and dates in the header either. It is also very important that the file header include the licensing statements present in the standard file header.

- Kevin

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1978/#review6409
-----------------------------------------------------------

On June 8, 2012, 2:04 p.m., jrose wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1978/
> -----------------------------------------------------------
> 
> (Updated June 8, 2012, 2:04 p.m.)
> 
> 
> Review request for Asterisk Developers, Mark Michelson, Terry Wilson, and Olle E Johansson.
> 
> 
> Summary
> -------
> 
> This feature is based on oej's deluxepine (or something like that) branch with a similarly named feature.  ACLs are defined in acl.conf and can be used by pretty much anything that has ACL options permit/deny (acl='aclname').  acl= works similarly to permit= and deny= in that it simply appends to the working ACL, so they can be combined with other uses of permit/deny/acl.
> 
> Also in use in this patch are twilson's new config options.
> 
> Since named acls are duplicated when used in another configuration, configurations that use named acls need to be updated if acl.conf is reloaded. This is accomplished with a new event type and the consumption of that event is demonstrated currently only in manager.conf
> If this seems like a proper approach to this problem, that will be replicated across other consumers of named acls.
> 
> NOTE: This code is very much WIP and not intended for merging.
> 
> 
> Diffs
> -----
> 
>   /trunk/CHANGES 368662 
>   /trunk/channels/chan_h323.c 368662 
>   /trunk/channels/chan_iax2.c 368662 
>   /trunk/channels/chan_mgcp.c 368662 
>   /trunk/channels/chan_sip.c 368662 
>   /trunk/channels/chan_skinny.c 368662 
>   /trunk/channels/chan_unistim.c 368662 
>   /trunk/configs/acl.conf.sample PRE-CREATION 
>   /trunk/configs/iax.conf.sample 368662 
>   /trunk/configs/manager.conf.sample 368662 
>   /trunk/configs/sip.conf.sample 368662 
>   /trunk/configs/skinny.conf.sample 368662 
>   /trunk/include/asterisk/acl.h 368662 
>   /trunk/include/asterisk/event_defs.h 368662 
>   /trunk/main/acl.c 368662 
>   /trunk/main/asterisk.c 368662 
>   /trunk/main/manager.c 368662 
>   /trunk/main/named_acl.c PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/1978/diff
> 
> 
> Testing
> -------
> 
> Various tests for configuring and using named acls were performed, and a task for writing comprehensive testsuite tests is in the queue.  Additionally, various means of reloading the configuration have been performed, and so far they pan out aside from a bug with an unchanged acl.conf which is a generic problem against config options accidentally introduced a little while back.
> 
> 
> Thanks,
> 
> jrose
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120609/cbc6bac0/attachment-0001.htm>

------------------------------

_______________________________________________
--Bandwidth and Colocation Provided by http://www.api-digital.com--

AstriCon 2010 - October 26-28 Washington, DC
Put in your talk proposal: http://www.bit.ly/speak-astricon2010

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

End of asterisk-dev Digest, Vol 95, Issue 41
********************************************

------------------------------

Message: 2
Date: Sun, 10 Jun 2012 13:20:34 -0000
From: "Russell Bryant" <reviewboard at asterisk.org>
Subject: Re: [asterisk-dev] [Code Review] Add AMI event documentation
To: , "Mark Michelson" <mmichelson at digium.com>
Cc: Russell Bryant <reviewboard at asterisk.org>,	Asterisk Developers
	<asterisk-dev at lists.digium.com>
Message-ID: <20120610132034.2003.37660 at hotblack.digium.com>
Content-Type: text/plain; charset="utf-8"

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1967/#review6429
-----------------------------------------------------------

super awesome patch.

./trunk/Makefile
<https://reviewboard.asterisk.org/r/1967/#comment12116>

    Is 'make full' so python isn't a build dependency?  Or is it to avoid the additional time in the build?

./trunk/Makefile
<https://reviewboard.asterisk.org/r/1967/#comment12117>

    It would be good to update validate-docs, too

./trunk/build_tools/get_documentation.py
<https://reviewboard.asterisk.org/r/1967/#comment12110>

    If you care about making the formatting conform to PEP8:

    $ pep8 build_tools/get_documentation.py 
    build_tools/get_documentation.py:17:1: E302 expected 2 blank lines, found 1
    build_tools/get_documentation.py:26:1: E302 expected 2 blank lines, found 1
    build_tools/get_documentation.py:48:18: E702 multiple statements on one line (semicolon)
    build_tools/get_documentation.py:57:80: E501 line too long (104 characters)
    build_tools/get_documentation.py:57:67: E231 missing whitespace after ','
    build_tools/get_documentation.py:79:80: E501 line too long (118 characters)
    build_tools/get_documentation.py:80:66: E231 missing whitespace after ','
    build_tools/get_documentation.py:108:52: E231 missing whitespace after ','
    build_tools/get_documentation.py:109:38: W291 trailing whitespace
    build_tools/get_documentation.py:110:80: E501 line too long (81 characters)
    build_tools/get_documentation.py:111:80: E501 line too long (91 characters)
    build_tools/get_documentation.py:116:80: E501 line too long (120 characters)
    build_tools/get_documentation.py:118:1: E302 expected 2 blank lines, found 1
    build_tools/get_documentation.py:160:26: W292 no newline at end of file

./trunk/build_tools/get_documentation.py
<https://reviewboard.asterisk.org/r/1967/#comment12112>

    You can also do:

        for line in sys.stdin:

./trunk/build_tools/get_documentation.py
<https://reviewboard.asterisk.org/r/1967/#comment12111>

    Did you mean if len(line) here?

    If line was None, an Exception would occur on the line before this one.

./trunk/build_tools/get_documentation.py
<https://reviewboard.asterisk.org/r/1967/#comment12113>

    Did you mean if not len(parameter) ?

./trunk/build_tools/post_process_documentation.py
<https://reviewboard.asterisk.org/r/1967/#comment12114>

    If you care about PEP8:

    $ pep8 build_tools/post_process_documentation.py 
    build_tools/post_process_documentation.py:18:1: E302 expected 2 blank lines, found 1
    build_tools/post_process_documentation.py:26:80: E501 line too long (89 characters)
    build_tools/post_process_documentation.py:29:80: E501 line too long (95 characters)
    build_tools/post_process_documentation.py:32:80: E501 line too long (117 characters)
    build_tools/post_process_documentation.py:36:80: E501 line too long (97 characters)
    build_tools/post_process_documentation.py:38:80: E501 line too long (98 characters)
    build_tools/post_process_documentation.py:40:1: E302 expected 2 blank lines, found 1
    build_tools/post_process_documentation.py:47:1: E302 expected 2 blank lines, found 1
    build_tools/post_process_documentation.py:65:1: E302 expected 2 blank lines, found 1
    build_tools/post_process_documentation.py:71:44: E251 no spaces around keyword / parameter equals
    build_tools/post_process_documentation.py:74:45: E251 no spaces around keyword / parameter equals
    build_tools/post_process_documentation.py:93:26: W292 no newline at end of file

./trunk/build_tools/post_process_documentation.py
<https://reviewboard.asterisk.org/r/1967/#comment12115>

    Holy nesting depth, batman

- Russell

On June 8, 2012, 8:33 a.m., Matt Jordan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1967/
> -----------------------------------------------------------
> 
> (Updated June 8, 2012, 8:33 a.m.)
> 
> 
> Review request for Asterisk Developers, Mark Michelson and wdoekes.
> 
> 
> Summary
> -------
> 
> This patch begins to add AMI event documentation to Asterisk.  This patch includes the following:
> 
> * Pulling AMI event XML documentation out of the Asterisk source and into the XML documentation produced by the build tools
> * Validating the XML when -dev-mode is enabled
> * Reading/parsing the XML documentation when Asterisk starts
> * Two new CLI commands: 'manager show events' and 'manager show event [event_name]'
> * Event documentation for the core applications
> 
> So... AMI events are a bit trickier then other things we've attempted to document in the past.  There were a number of factors to consider when approaching this:
> 1. There are a lot of AMI events, and they are located throughout the code base
> 2. AMI events can occur multiple times with different parameters, but still be the same 'event' type
> 3. AMI events can occur multiple times, in different implementation files
> 4. There is a significant amount of repeated information between events
> 5. Much of the information that a person cares about (AMI event keys) are - more often then not - easily obtained from a method call
> 
> To that end, documentation for AMI events is treated a bit differently then other items.  There are a few major shifts in how the documentation is extracted:
> 1. The previous documentation extraction used an awk script that pulled the documentation from a single comment block (delineated by /*** DOCUMENTATION ... ***/).  That still exists; however, if you want AMI event documentation, you have to use 'make full'.  This calls a different documentation extraction script, written in python.  That script lets us do a few things that the awk script did not:
>  * Documentation can now exist anywhere in the source file
>  * The documentation for manager events can be co-located with the method calls that raise the event.  If the method call is recognized, event parameters are automatically read from the method call and populated in the documentation
>  * Documentation is combined where appropriate.  Thus, if the same event is raised in multiple places, the parameters only need to be defined once.
> 2. Previously, documentation was registered with the application/function/command that it was associated with.  Events are never registered with any controller; requiring them to do so would incur a run-time performance penalty for little gain.  Hence, the xmldoc core now allow documentation for an entire source type to be requested at run-time.  When requested, the documentation is built from the XML read in.
> 
> Example manager events:
> 
> Event: ChanSpyStart
> [Synopsis]
> Raised when a channel has started spying on another channel.
> 
> [Syntax]
> Event: ChanSpyStart
> SpyerChannel: <value>
> SpyeeChannel: <value>
> 
> [See Also]
> ChanSpy(), ExtenSpy(), ChanSpyStop
> 
> -----------------------
> 
> Event: Dial
> [Synopsis]
> Raised when a dial action has started.
> 
> [Syntax]
> Event: Dial
> SubEvent: <value>
> Channel: <value>
> Destination: <value>
> CallerIDNum: <value>
> CallerIDName: <value>
> ConnectedLineNum: <value>
> ConnectedLineName: <value>
> UniqueID: <value>
> DestUniqueID: <value>
> Dialstring: <value>
> 
> [Arguments]
> SubEvent
>     Begin
>     End
>     A sub event type, specifying whether or not the dial action has begun
>     or ended.
> 
> [Synopsis]
> Raised when a dial action has ended.
> 
> [Syntax]
> Event: Dial
> DialStatus: <value>
> SubEvent: <value>
> Channel: <value>
> UniqueID: <value>
> 
> [Arguments]
> DialStatus
>     The value of the ${DIALSTATUS} channel variable.
> SubEvent
>     Begin
>     End
>     A sub event type, specifying whether or not the dial action has begun
>     or ended.
> 
> ---------------------------------
> 
> Event: QueueMemberStatus
> [Synopsis]
> Raised when a Queue member's status has changed.
> 
> [Syntax]
> Event: QueueMemberStatus
> Queue: <value>
> Location: <value>
> MemberName: <value>
> StateInterface: <value>
> Membership: <value>
> Penalty: <value>
> CallsTaken: <value>
> LastCall: <value>
> Status: <value>
> Paused: <value>
> 
> [Arguments]
> Queue
>     The name of the queue.
> Location
>     The queue member's channel technology or location.
> MemberName
>     The name of the queue member.
> StateInterface
>     Channel technology or location from which to read device state
>     changes.
> Membership
>     dynamic
>     realtime
>     static
> Penalty
>     The penalty associated with the queue member.
> CallsTaken
>     The number of calls this queue member has serviced.
> LastCall
>     The time this member last took call, expressed in seconds since 00:00,
>     Jan 1, 1970 UTC.
> Status
>     The status of the queue member.  This will be a device state value.
> Paused
>     0
>     1
> 
> 
> Diffs
> -----
> 
>   ./configure UNKNOWN 
>   ./trunk/Makefile 367982 
>   ./trunk/apps/app_chanspy.c 367982 
>   ./trunk/apps/app_confbridge.c 367982 
>   ./trunk/apps/app_dial.c 367982 
>   ./trunk/apps/app_meetme.c 367982 
>   ./trunk/apps/app_queue.c 367982 
>   ./trunk/apps/app_stack.c 367982 
>   ./trunk/apps/app_userevent.c 367982 
>   ./trunk/apps/app_voicemail.c 367982 
>   ./trunk/build_tools/get_documentation.py PRE-CREATION 
>   ./trunk/build_tools/post_process_documentation.py PRE-CREATION 
>   ./trunk/configure.ac 367982 
>   ./trunk/doc/appdocsxml.dtd 367982 
>   ./trunk/include/asterisk/xmldoc.h 367982 
>   ./trunk/main/manager.c 367982 
>   ./trunk/main/xmldoc.c 367982 
>   ./trunk/makeopts.in 367982 
> 
> Diff: https://reviewboard.asterisk.org/r/1967/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Matt
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120610/32270567/attachment.htm>

------------------------------

_______________________________________________
--Bandwidth and Colocation Provided by http://www.api-digital.com--

AstriCon 2010 - October 26-28 Washington, DC
Put in your talk proposal: http://www.bit.ly/speak-astricon2010

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

End of asterisk-dev Digest, Vol 95, Issue 42
********************************************