[asterisk-dev] [Code Review] Make the ACL default handler more consistent with other default handlers and document how each handler works

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1969/#review6403
-----------------------------------------------------------

Ship it!


I agree with Jonathan. Go!

- Mark


On June 6, 2012, 12:12 a.m., Terry Wilson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1969/
> -----------------------------------------------------------
> 
> (Updated June 6, 2012, 12:12 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> In adding documentation to the default handlers in main/config_options.c, I noticed that I had written the ACL handler to take an additional argument instead of using the flags parameter to specify whether or not this was a permit or deny. Since the codec handler uses the flag for allow/disallow parsing, I changed the ACL handler to behave the same.
> 
> 
> Diffs
> -----
> 
>   /trunk/main/config_options.c 368552 
>   /trunk/include/asterisk/config_options.h 368552 
>   /trunk/tests/test_config.c 368552 
> 
> Diff: https://reviewboard.asterisk.org/r/1969/diff
> 
> 
> Testing
> -------
> 
> Updated the test and it still passes.
> 
> 
> Thanks,
> 
> Terry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120607/92d58c66/attachment.htm>