[asterisk-dev] [Code Review] Patch to detect/parse ANI-II / ANI2 / OLI from SIP INVITE messages

[opticron]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1947/#review6386
-----------------------------------------------------------



/trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/1947/#comment11968>

    Initialize to NULL.



/trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/1947/#comment11967>

    It is not possible for req to be NULL where this function is called since Asterisk would have already segfaulted.



/trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/1947/#comment11970>

    It is probably better to use sscanf here instead of custom parsing logic since it appears that ANI will always be numeric.


- opticron


On May 30, 2012, 12:43 p.m., Rob Gagnon wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1947/
> -----------------------------------------------------------
> 
> (Updated May 30, 2012, 12:43 p.m.)
> 
> 
> Review request for Asterisk Developers, Mark Michelson, rmudgett, and Rob Gagnon.
> 
> 
> Summary
> -------
> 
> Add ANI2 / OLI parsing for SIP.  The patch checks the "From" header during the handle_request_invite() function for the presence of "isup-oli", "ss7-oli", or "oli" tags.  If present, the up-to-2-digits following the equal sign in the tag are set on the channel's caller structure in the "ani2" int element.
> 
> This allows SIP functions that reference ANI2 to work properly for SIP.  Specifically tested was the messaging that occurs when AGI transmits its data to an AGI script.
> 
> 
> This addresses bug ASTERISK-19912.
>     https://issues.asterisk.org/jira/browse/ASTERISK-19912
> 
> 
> Diffs
> -----
> 
>   /trunk/channels/chan_sip.c 367975 
> 
> Diff: https://reviewboard.asterisk.org/r/1947/diff
> 
> 
> Testing
> -------
> 
> Call processing via AGI call in dial plan which logs all AGI incoming values was executed from cell phone, land line, and payphone.  During the payphone call, the value of "agi_callingani2" was properly transmitted as "7" for the payphone, "62" for the cell phone, and "0" for the landline.
> 
> Over 600,000 calls have been processed in 12 hours or more of testing without errors.
> 
> 
> Thanks,
> 
> Rob
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120606/17608514/attachment-0001.htm>