[asterisk-dev] [Code Review]: Remove global module flag from app_voicemail.

[rmudgett]

> On June 5, 2012, 11:55 a.m., Jason Parker wrote:
> > /certified/branches/1.8.11/apps/app_voicemail.c, line 14346
> > <https://reviewboard.asterisk.org/r/1965/diff/1/?file=28458#file28458line14346>
> >
> >     I'm ever-so-slightly concerned about this ast_calloc() call.  Does it look right?

Yes.  You are allocating room for an an array of list headers.


- rmudgett


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1965/#review6381
-----------------------------------------------------------


On June 5, 2012, 11:49 a.m., Jason Parker wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1965/
> -----------------------------------------------------------
> 
> (Updated June 5, 2012, 11:49 a.m.)
> 
> 
> Review request for Asterisk Developers and Mark Michelson.
> 
> 
> Summary
> -------
> 
> This causes app_voicemail to register functions that were previously global, in the same way that other functions are already registered.
> 
> The API changes a bit, but callers will only need to make a minor change, as the number of folders is no longer static.
> 
> 
> Diffs
> -----
> 
>   /certified/branches/1.8.11/apps/app_voicemail.c 368244 
>   /certified/branches/1.8.11/include/asterisk/app.h 368244 
>   /certified/branches/1.8.11/include/asterisk/app_voicemail.h 368244 
>   /certified/branches/1.8.11/main/app.c 368244 
>   /certified/branches/1.8.11/tests/test_voicemail_api.c 368244 
> 
> Diff: https://reviewboard.asterisk.org/r/1965/diff
> 
> 
> Testing
> -------
> 
> It compiles, and functions can be called the same way they are today.
> 
> 
> Thanks,
> 
> Jason
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120605/511c6f19/attachment-0001.htm>