[asterisk-dev] Sending patch to Review Board

[Matthew Jordan]

----- Original Message -----
> From: "Jeremy Kister" <asterisk-dev-01 at jeremykister.com>
> To: asterisk-dev at lists.digium.com
> Sent: Tuesday, June 5, 2012 10:45:27 AM
> Subject: [asterisk-dev] Sending patch to Review Board
> 
> Hi Devs,
> 
> I am attempting to put my small patch on ASTERISK-18046 on
> ReviewBoard.
> 
> However, RB always complains 'Unable to parse diff revision header'
> which, according to google, has something to do with CVS.

Review Board expects diffs to be in unified diff format from a 
Subversion repository.  I certainly hope the diff you attempted 
to upload wasn't from CVS.

That error message can occur whenever the revision specifier
in the diff is in a format that Review Board doesn't understand.
I'm going to assume that you tried uploading the diff you have
on the ASTERISK issue.

1. Diffs that have manually edited comments in them are highly
unlikely to work
2. Your revision specifiers appear to be different then what
'svn diff' produces for me:

Yours:

Mine:


Have you tried using the post-review tool?

https://wiki.asterisk.org/wiki/display/AST/Reviewboard+Usage

> I'm not (and don't plan to be) a very active code contributor - is
> there
> a simple solution?
> 
> Thanks.
> 
> --
> 
> Jeremy Kister
> http://jeremy.kister.net./



--
Matthew Jordan
Digium, Inc. | Software Developer
445 Jan Davis Drive NW - Huntsville, AL 35806 - USA
Check us out at: http://digium.com & http://asterisk.org