[asterisk-dev] [Code Review] Bring the (missing) changes from Mantis ID 13495 in trunk.

[opticron]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1653/#review6373
-----------------------------------------------------------



trunk/isup.c
<https://reviewboard.asterisk.org/r/1653/#comment11910>

    These should consistently return either hex or decimal.  Also, where did 'E' come from in DTMF?  It is not part of any description I can find.



trunk/isup.c
<https://reviewboard.asterisk.org/r/1653/#comment11911>

    The case statements here should be consistent with either hex or decimal, not both.


In addition to these changes, please edit the summary and description of this review (and the related review, 1676) to describe the changes presented.  I see quite a bit of fleshing out partially complete functions and a lot of code cleanup, but there are other changes here as well.

- opticron


On April 23, 2012, 9:46 a.m., KNK wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1653/
> -----------------------------------------------------------
> 
> (Updated April 23, 2012, 9:46 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> libss7 part of the changes only
> 
> 
> This addresses bugs SS7-27, SS7-52 and SS7-53.
>     https://issues.asterisk.org/jira/browse/SS7-27
>     https://issues.asterisk.org/jira/browse/SS7-52
>     https://issues.asterisk.org/jira/browse/SS7-53
> 
> 
> Diffs
> -----
> 
>   trunk/isup.h 296 
>   trunk/isup.c 296 
>   trunk/libss7.h 296 
>   trunk/mtp2.h 296 
>   trunk/mtp2.c 296 
>   trunk/mtp3.h 296 
>   trunk/mtp3.c 296 
>   trunk/ss7.c 296 
>   trunk/ss7_internal.h 296 
> 
> Diff: https://reviewboard.asterisk.org/r/1653/diff
> 
> 
> Testing
> -------
> 
> compiles, link setup, cli commands, bassic calls, connected line and redirection
> 
> 
> Thanks,
> 
> KNK
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120604/a7056c4b/attachment-0001.htm>