[asterisk-dev] [Code Review] Update Data of Queues (use queues as outbound calls container)

[Paul Belanger]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1958/#review6377
-----------------------------------------------------------


Please read https://wiki.asterisk.org/wiki/display/AST/Coding+Guidelines, you need to format your code to it.  Also, lots of red blobs.


trunk/apps/app_queue.c
<https://reviewboard.asterisk.org/r/1958/#comment11916>

    Do not declare variables mid-block, move them to the top



trunk/apps/app_queue.c
<https://reviewboard.asterisk.org/r/1958/#comment11915>

    invert logic


- Paul


On June 4, 2012, 9:52 a.m., sum wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1958/
> -----------------------------------------------------------
> 
> (Updated June 4, 2012, 9:52 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> this adds a new dialplan function QueueUpdate, with this is possible using it at h exten to have Outbound queues.
> 
> The idea is to be able to track in realtime outbound calls (completed, canceled) this will also log a new event on queue_log OUTCALL
> that has information about these calls.
> 
> has to be invoked on h exten
> 
> https://issues.asterisk.org/jira/browse/ASTERISK-19862
> 
> 
> Diffs
> -----
> 
>   trunk/apps/app_queue.c 368403 
> 
> Diff: https://reviewboard.asterisk.org/r/1958/diff
> 
> 
> Testing
> -------
> 
> compile on trunk
> heavily tested on 1.8.X and 1.6.2.X
> 
> 
> Thanks,
> 
> sum
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120604/b829af04/attachment-0001.htm>