[asterisk-dev] [Code Review] Patch to make app_system check if a command failed to execute due to permission denied.

[jrose]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1956/#review6375
-----------------------------------------------------------



/trunk/apps/app_system.c
<https://reviewboard.asterisk.org/r/1956/#comment11913>

    This looks mostly fine, but I'm having trouble finding any particular resource which definitively pegs this particular status from wait4 as indicating what is implied.  I don't know.
    
    Looking at the man page for wait4, I think reading specific values to evaluate success or failure might be the wrong way to go and instead perhaps the macros listed on the man page might be more proper.


- jrose


On June 4, 2012, 9:23 a.m., Dennis Martinez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1956/
> -----------------------------------------------------------
> 
> (Updated June 4, 2012, 9:23 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> I created a patch that improves the app_system behavior.  The patch should make this application to check if a command failed to execute due to permission denied.
> 
> 
> This addresses bug ASTERISK-19935.
>     https://issues.asterisk.org/jira/browse/ASTERISK-19935
> 
> 
> Diffs
> -----
> 
>   /trunk/apps/app_system.c 368031 
> 
> Diff: https://reviewboard.asterisk.org/r/1956/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dennis
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120604/8358308c/attachment.htm>