[asterisk-dev] [Code Review]: Bring the (missing) changes from Mantis ID 13495 in trunk.

[KNK]

> On June 4, 2012, 8:08 a.m., opticron wrote:
> > trunk/isup.c, lines 241-280
> > <https://reviewboard.asterisk.org/r/1653/diff/10/?file=27453#file27453line241>
> >
> >     These should consistently return either hex or decimal.  Also, where did 'E' come from in DTMF?  It is not part of any description I can find.

Fixed in the next version.
About 'E' - here in Bulgaria, the number portability is described as 'prefixed with E', which in fact is 0xe. I am not sure if it comes from Siemens or Ericson equipment, but that's what the incumbent telco uses describing it.


On June 4, 2012, 8:08 a.m., KNK wrote:
> > In addition to these changes, please edit the summary and description of this review (and the related review, 1676) to describe the changes presented.  I see quite a bit of fleshing out partially complete functions and a lot of code cleanup, but there are other changes here as well.

I am not sure i understand what you mean with "fleshing out partially complete functions".
The changes here are based on the patches from the issue 13495, but with some (lots of) modifications to make them compatible with the current Asterisk version. The cleanup was based on the previous review and in order to remove the red blobs. The only additions (not included in the issue are "additional cause codes, Transmission Medium Requirement setting and connected line to CPG messages", which i will add to the description.


- KNK


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1653/#review6373
-----------------------------------------------------------


On June 4, 2012, 9:40 a.m., KNK wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1653/
> -----------------------------------------------------------
> 
> (Updated June 4, 2012, 9:40 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> libss7 part of the changes.
> Added additional cause codes, Transmission Medium Requirement setting and connected line to CPG messages + code cleanup.
> 
> 
> This addresses bugs SS7-27, SS7-52 and SS7-53.
>     https://issues.asterisk.org/jira/browse/SS7-27
>     https://issues.asterisk.org/jira/browse/SS7-52
>     https://issues.asterisk.org/jira/browse/SS7-53
> 
> 
> Diffs
> -----
> 
>   trunk/isup.h 296 
>   trunk/isup.c 296 
>   trunk/libss7.h 296 
>   trunk/mtp2.h 296 
>   trunk/mtp2.c 296 
>   trunk/mtp3.h 296 
>   trunk/mtp3.c 296 
>   trunk/ss7.c 296 
>   trunk/ss7_internal.h 296 
> 
> Diff: https://reviewboard.asterisk.org/r/1653/diff
> 
> 
> Testing
> -------
> 
> compiles, link setup, cli commands, bassic calls, connected line and redirection
> 
> 
> Thanks,
> 
> KNK
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120604/659ebc4b/attachment-0001.htm>