[asterisk-dev] [Code Review] Remove AST_FLAG_ANSWERED_ELSEWHERE, duplicating the functionality of AST_CAUSE_ANSWERED_ELSEWHERE

[opticron]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1944/#review6371
-----------------------------------------------------------

Ship it!


I'd say this is good to go!  AST_CAUSE_ANSWERED_ELSEWHERE isn't used very much, so there should be very little impact on existing behaviors.


trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/1944/#comment11908>

    This block can be removed since it will always be "the cause code, buddy".


- opticron


On May 25, 2012, 7:19 p.m., Birger Harzenetter wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1944/
> -----------------------------------------------------------
> 
> (Updated May 25, 2012, 7:19 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> While 'real' channels use AST_CAUSE_ANSWERED_ELSEWHERE, local channels and queues use AST_FLAG_ANSWERED_ELSEWHERE for the same purpose.
> This patch replaces all occurrences of the flag by the cause code, removing the duplicated functionality and the flag itself.
> 
> 
> Diffs
> -----
> 
>   trunk/apps/app_dial.c 367361 
>   trunk/apps/app_queue.c 367361 
>   trunk/channels/chan_local.c 367361 
>   trunk/channels/chan_sip.c 367361 
>   trunk/channels/chan_unistim.c 367361 
>   trunk/include/asterisk/channel.h 367361 
>   trunk/main/channel_internal_api.c 367361 
>   trunk/main/features.c 367361 
> 
> Diff: https://reviewboard.asterisk.org/r/1944/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Birger
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120601/2c05f67c/attachment-0001.htm>