[asterisk-dev] [Code Review]: Changes from Mantis ID 13495 in trunk.

[KNK]

> On July 19, 2012, 7:50 p.m., rmudgett wrote:
> > trunk/channels/chan_dahdi.c, line 14185
> > <https://reviewboard.asterisk.org/r/1676/diff/6/?file=29255#file29255line14185>
> >
> >     Move dahdi_ss7_hangup(), dahdi_ss7_call_null(), and dahdi_ss7_notinservice() into sig_ss7.c with appropriate new names sig_ss7_cb_hangup(), sig_ss7_cb_call_null(), and sig_ss7_cb_notinservice().  You will need to lock the owner pointer and sig_ss7_lock_owner() is a private function of sig_ss7.c.
> >     
> >     Also calling the callbacks in the manner you are doing is not the intended method.
> >     
> >     sig_ss7.c was extracted out of chan_dahdi to isolate the DAHDI specific code to chan_dahdi.

Done.


> On July 19, 2012, 7:50 p.m., rmudgett wrote:
> > trunk/channels/chan_dahdi.c, lines 14169-14174
> > <https://reviewboard.asterisk.org/r/1676/diff/6/?file=29255#file29255line14169>
> >
> >     Turn this snippet of code into a callback function like my_ss7_set_loopback().
> >     
> >     struct sig_ss7_linkset *my_ss7_find_linkset(struct ss7 *ss7);

Not sure i did the right thing here, but i couldn't find a way to call a callback in ss7_find_pvt() from struct *ss7, so i have declared extern dahdi_ss7_find_linkset() in sig_ss7.h to be able to call it.


- KNK


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1676/#review6756
-----------------------------------------------------------


On July 27, 2012, 2 p.m., KNK wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1676/
> -----------------------------------------------------------
> 
> (Updated July 27, 2012, 2 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> chan_dahdi / sig_ss7 part of changes
> 
> 
> This addresses bug SS7-27.
>     https://issues.asterisk.org/jira/browse/SS7-27
> 
> 
> Diffs
> -----
> 
>   trunk/channels/chan_dahdi.c 370452 
>   trunk/channels/sig_ss7.h 370452 
>   trunk/channels/sig_ss7.c 370452 
> 
> Diff: https://reviewboard.asterisk.org/r/1676/diff
> 
> 
> Testing
> -------
> 
> compiles, link setup, cli commands, bassic calls, connected line and redirection.
> 
> 
> Thanks,
> 
> KNK
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120731/c00b34ce/attachment.htm>