[asterisk-dev] [Code Review] Ensure that CDRs for a caller in a Queue who is not answered is NO ANSWER

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2064/
-----------------------------------------------------------

Review request for Asterisk Developers.


Summary
-------

When a caller enters a queue and no queue member answers the call, some odd behavior can be reporter in the resulting CDR records, depending on the state of certain queue members.

* If no queue members are paused, the CDR result is whatever the result was prior to going into app_queue.  If the call was answered, this is ANSWERED; otherwise, it is NO ANSWER.
* If some queue members are paused, the CDR result is BUSY.  This patch changes this to NO ANSWER.
* If all queue members are paused, the CDR result is again whatever the result was prior to going into app_queue.
* If the caller hangs up, times out, or presses '*' with the 'h' option, the result is again not set.

Similar to app_dial, if the caller in the queue does not get answered, we should set the CDR record appropriately.  In general, for the scenarios listed above, this is NO ANSWER.

This patch is a only slightly modified version of the one supplied by the issue reporter.

Since this is arguably a change in behavior, some tests were written to cover portions of this behavior in https://reviewboard.asterisk.org/r/2063.


This addresses bug AST-906.
    https://issues.asterisk.org/jira/browse/AST-906


Diffs
-----

  /branches/1.8/apps/app_queue.c 370418 

Diff: https://reviewboard.asterisk.org/r/2064/diff


Testing
-------


Thanks,

Matt

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120725/ea77fecb/attachment.htm>