[asterisk-dev] [Code Review] Add test for subscribing for MWI notifications from external sources using a Test Object that manages SIPp scenarios

Matt Jordan reviewboard at asterisk.org
Wed Jul 25 09:28:29 CDT 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2059/
-----------------------------------------------------------

(Updated July 25, 2012, 9:28 a.m.)


Review request for Asterisk Developers and Mark Michelson.


Changes
-------

Addressed Mark's findings.  Now with a lot more observers.

You can get notified when:

* Any SIPp scenario starts
* Any SIPp scenario stops
* A set of SIPp scenarios finishes
* When all SIPp scenarios finish

Everything is now run in a single sequential sequence, where each entry in the sequence is a set of SIPp scenario to run in parallel.


Summary
-------

This test introduces a fairly straight forward test that covers Asterisk sending a SUBSCRIBE request for MWI notifications, and receiving a corresponding NOTIFY request from the external source.  This test does not attempt to cover the event system's dispensing of MWI notifications to Asterisk modules; rather it only attempts to cover chan_sip's responsibilities in sending a SIP SUBSCRIBE request/receiving a SIP NOTIFY request.

As part of this, a new test object was written for the pluggable framework that orchestrates SIPp scenarios against a single instance of Asterisk.  SIPp scenarios can be executed in a sequence, and in parallel.  The test object includes entry points for custom modules to register themselves as observers between SIPp scenario executions - either between any scenario executed in parallel, or between sets of scenarios executed in sequence.


This addresses bugs ASTERISK-19827 and ASTERISK-19939.
    https://issues.asterisk.org/jira/browse/ASTERISK-19827
    https://issues.asterisk.org/jira/browse/ASTERISK-19939


Diffs (updated)
-----

  /asterisk/trunk/lib/python/asterisk/sipp.py 3325 
  /asterisk/trunk/sample-yaml/sipptestcase-config.yaml.sample PRE-CREATION 
  /asterisk/trunk/tests/channels/SIP/subscribe/configs/ast1/sip.conf PRE-CREATION 
  /asterisk/trunk/tests/channels/SIP/subscribe/sipp/uas_subscribe_mwi.xml PRE-CREATION 
  /asterisk/trunk/tests/channels/SIP/subscribe/test-config.yaml PRE-CREATION 
  /asterisk/trunk/tests/channels/SIP/tests.yaml 3348 

Diff: https://reviewboard.asterisk.org/r/2059/diff


Testing
-------


Thanks,

Matt

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120725/8cdfa42e/attachment.htm>


More information about the asterisk-dev mailing list