[asterisk-dev] [Code Review] func_jitterbuffer tests

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2021/#review6777
-----------------------------------------------------------



/asterisk/trunk/tests/funcs/func_jitterbuffer/configs/ast1/extensions.conf
<https://reviewboard.asterisk.org/r/2021/#comment12991>

    You've got a stray lowercase 'u' in "CuRRENT_TEST_TYPE". This means that default_jbs are never being set up.
    
    If the test is still passing despite this typo, I think that demonstrates a flaw in the test procedure. Specifically, there is nothing to ensure that you are receiving the test events you expect to be receiving. Receiving correct test events and receiving no test events both result in the test passing. You should modify the test to keep a counter of the test events received to ensure that a jitter buffer actually gets set up and that it sends the expected number of test events.



/asterisk/trunk/tests/funcs/func_jitterbuffer/run-test
<https://reviewboard.asterisk.org/r/2021/#comment12997>

    I imagine this may be cruft left over from when this was testing DTMF jitterbuffers, but the TestResult user event will never have a result of "fail". You might as well just go straight into self._launch_talk_detect() when you receive a TestResult event, and you might as well just remove the result field from the event altogether.


- Mark


On July 12, 2012, 1:30 p.m., Matt Jordan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2021/
> -----------------------------------------------------------
> 
> (Updated July 12, 2012, 1:30 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This adds a new test to the Asterisk Test Suite that covers the JITTERBUFFER function.  This includes tests for the following:
> 
> * JITTERBUFFER(type)=default
> * JITTERBUFFER(type)=max_size,resync,target_extra
> 
> The variants in each test are:
> 
> type => adaptive or fixed jitter buffers
> max_size => default, 1000, 2000
> target_extra => default, 10, 50
> resync => default, 2000, 500
> 
> For each test, the following are checked:
> 
> * The JITTERBUFFER function creates a jitter buffer with the specified properties
> * That voice are streamed properly through a jitter buffer.  This uses the Record application, allong with BackgroundDetect for the recorded voice files.
> 
> This patch also groups all function tests under a new folder, "funcs"
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/funcs/func_jitterbuffer/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/funcs/func_jitterbuffer/configs/ast1/sip.conf PRE-CREATION 
>   /asterisk/trunk/tests/funcs/func_jitterbuffer/run-test PRE-CREATION 
>   /asterisk/trunk/tests/funcs/func_jitterbuffer/talking.ulaw UNKNOWN 
>   /asterisk/trunk/tests/funcs/func_jitterbuffer/test-config.yaml PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/2021/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Matt
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120723/eb655e5d/attachment.htm>