[asterisk-dev] [Code Review]: Bring the (missing) changes from Mantis ID 13495 in trunk.

[rmudgett]

> On July 19, 2012, 2:06 p.m., rmudgett wrote:
> > branches/1.0/isup.c, lines 406-407
> > <https://reviewboard.asterisk.org/r/1653/diff/14/?file=30251#file30251line406>
> >
> >     This is a difference between the (ex)trunk and the 1.0 branch.  Which way does it need to be done?
> 
> KNK wrote:
>     Actually both are wrong, as they are bit fields and should be checked as (cci & 0x1) even if cot_check_required and cot_performed_on_previous_cic should never both be set. Fixed in both versions and also added it to transmission where it was missing.

The change in the v1.0 branch was added in -r286 with the commit message:
We should be waiting to cut through the circuit until we get a COT even in cases where we get an indicator of a COT test on a previous circuit

This may have been done so Asterisk would start a continuity loopback test when processing an IAM message.


- rmudgett


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1653/#review6750
-----------------------------------------------------------


On July 13, 2012, 2:41 p.m., KNK wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1653/
> -----------------------------------------------------------
> 
> (Updated July 13, 2012, 2:41 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> libss7 part of the changes.
> Added additional cause codes, Transmission Medium Requirement setting and connected line to CPG messages + code cleanup.
> 
> 
> This addresses bugs SS7-21, SS7-27, SS7-28, SS7-33, SS7-36, SS7-38, SS7-39, SS7-40, SS7-42, SS7-43, SS7-45, SS7-46, SS7-47, SS7-48, SS7-49, SS7-51, SS7-52, SS7-53, SS7-54, and SS7-7.
>     https://issues.asterisk.org/jira/browse/SS7-21
>     https://issues.asterisk.org/jira/browse/SS7-27
>     https://issues.asterisk.org/jira/browse/SS7-28
>     https://issues.asterisk.org/jira/browse/SS7-33
>     https://issues.asterisk.org/jira/browse/SS7-36
>     https://issues.asterisk.org/jira/browse/SS7-38
>     https://issues.asterisk.org/jira/browse/SS7-39
>     https://issues.asterisk.org/jira/browse/SS7-40
>     https://issues.asterisk.org/jira/browse/SS7-42
>     https://issues.asterisk.org/jira/browse/SS7-43
>     https://issues.asterisk.org/jira/browse/SS7-45
>     https://issues.asterisk.org/jira/browse/SS7-46
>     https://issues.asterisk.org/jira/browse/SS7-47
>     https://issues.asterisk.org/jira/browse/SS7-48
>     https://issues.asterisk.org/jira/browse/SS7-49
>     https://issues.asterisk.org/jira/browse/SS7-51
>     https://issues.asterisk.org/jira/browse/SS7-52
>     https://issues.asterisk.org/jira/browse/SS7-53
>     https://issues.asterisk.org/jira/browse/SS7-54
>     https://issues.asterisk.org/jira/browse/SS7-7
> 
> 
> Diffs
> -----
> 
>   branches/1.0/ss7_internal.h 300 
>   branches/1.0/ss7linktest.c 300 
>   branches/1.0/libss7.h 300 
>   branches/1.0/mtp2.h 300 
>   branches/1.0/mtp2.c 300 
>   branches/1.0/mtp3.h 300 
>   branches/1.0/mtp3.c 300 
>   branches/1.0/parser_debug.c 300 
>   branches/1.0/ss7.c 300 
>   branches/1.0/isup.c 300 
>   branches/1.0/isup.h 300 
>   branches/1.0/ss7test.c 300 
> 
> Diff: https://reviewboard.asterisk.org/r/1653/diff
> 
> 
> Testing
> -------
> 
> compiles, link setup, cli commands, bassic calls, connected line and redirection
> 
> 
> Thanks,
> 
> KNK
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120720/6e55713b/attachment.htm>