[asterisk-dev] [Code Review] named_acl: Change systemname setting to use the globally set systemname from asterisk.conf

[jrose]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2057/
-----------------------------------------------------------

Review request for Asterisk Developers, Olle E Johansson and Matt Jordan.


Summary
-------

oej mentioned on #asterisk-dev about a week or so ago that I had implemented this incorrectly and that I should be using the global systemname option instead. This patch does that and dispenses with the acl.conf option to set it.

The general section is left in tact for now in spite of the fact that it has no options since getting it working was mildly painful and it's pretty easily conceivable that we'll want to add general options to acl.conf in the near future. Also, if it were removed Asterisk would reject the configuration entirely if a general section were included at all... so that would also be mildly annoying.


Diffs
-----

  /trunk/configs/acl.conf.sample 370226 
  /trunk/main/named_acl.c 370226 

Diff: https://reviewboard.asterisk.org/r/2057/diff


Testing
-------

It still compiles and generally works. It also doesn't break my tests.


Thanks,

jrose

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120718/70f49141/attachment.htm>