[asterisk-dev] [Code Review] Add a CELModule for configuration defined tests

Mark Michelson reviewboard at asterisk.org
Wed Jul 18 15:21:55 CDT 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2050/#review6723
-----------------------------------------------------------

Ship it!


If you can make the change opticron suggested, go for it. Other than that, looks good to me!

- Mark


On July 16, 2012, 1:29 p.m., Matt Jordan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2050/
> -----------------------------------------------------------
> 
> (Updated July 16, 2012, 1:29 p.m.)
> 
> 
> Review request for Asterisk Developers, Mark Michelson and Terry Wilson.
> 
> 
> Summary
> -------
> 
> This patch adds a CELModule to the Asterisk Test Suite for configuration defined tests.  As not much actually tests CEL records at this point, no tests were harmed in the making of this module.
> 
> Note that this parrots the behavior of the CDRModule, and can be configured in a similar manner - although instead of specifying CDR fields in each CSV line, CEL fields would be specified instead.
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/lib/python/asterisk/cel.py 3325 
> 
> Diff: https://reviewboard.asterisk.org/r/2050/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Matt
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120718/575ea147/attachment-0001.htm>


More information about the asterisk-dev mailing list