[asterisk-dev] [Code Review] Add TestEvents for callID changes on channels.

[jrose]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2054/#review6715
-----------------------------------------------------------



/trunk/main/channel_internal_api.c
<https://reviewboard.asterisk.org/r/2054/#comment12751>

    This is actually kind of silly, so I'm changing it to:
    
    call_identifier_from[0] = '\0';
    ast_callid_strnprint(call_identifier_to, sizeof(call_identifier_to), callid);
    if (chan->callid) {
    	ast_callid_strnprint(call_identifier_from, sizeof(call_identifier_from), chan->callid);
    	ast_debug(3, "Channel Call ID changing from %s to %s\n", call_identifier_from, call_identifier_to);
    	/* unbind if already set */
    	ast_callid_unref(chan->callid);
    }
    
    chan->callid = ast_callid_ref(callid);
    


- jrose


On July 18, 2012, 1:32 p.m., jrose wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2054/
> -----------------------------------------------------------
> 
> (Updated July 18, 2012, 1:32 p.m.)
> 
> 
> Review request for Asterisk Developers and Matt Jordan.
> 
> 
> Summary
> -------
> 
> Adds the issuing of a test event when a call ID is set on a channel and TEST_FRAMEWORK is enabled which will include the following information:
> Channel name
> Call ID previous to the change
> Call ID the channel was set to
> 
> There might not have been a callID set prior to the change, in which case the value for priorCallID will simply be an empty string.
> 
> 
> Diffs
> -----
> 
>   /trunk/main/channel_internal_api.c 370202 
> 
> Diff: https://reviewboard.asterisk.org/r/2054/diff
> 
> 
> Testing
> -------
> 
> Tested some call ID changes to see how they were behaving. The events seem like what was expected.
> 
> I'm also working on some testsuite tests that use this event.
> 
> 
> Thanks,
> 
> jrose
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120718/ff737f04/attachment.htm>