[asterisk-dev] [Code Review]: Revise skinny debugging messages

[wedhorn]

> On July 17, 2012, 6:29 p.m., Paul Belanger wrote:
> > trunk/channels/chan_skinny.c, lines 3510-3512
> > <https://reviewboard.asterisk.org/r/2040/diff/3/?file=30349#file30349line3510>
> >
> >     invert logic

pseudo code of the statement:

if arg == "off" then
     skinnydebug = 0
else

inverting would reduced readability.


> On July 17, 2012, 6:29 p.m., Paul Belanger wrote:
> > trunk/channels/chan_skinny.c, line 3545
> > <https://reviewboard.asterisk.org/r/2040/diff/3/?file=30349#file30349line3545>
> >
> >     if (!bitmask) continue?

done.


> On July 17, 2012, 6:29 p.m., Paul Belanger wrote:
> > trunk/channels/chan_skinny.c, line 6462
> > <https://reviewboard.asterisk.org/r/2040/diff/3/?file=30349#file30349line6462>
> >
> >     OMGBLOB

fixed


> On July 17, 2012, 6:29 p.m., Paul Belanger wrote:
> > trunk/channels/chan_skinny.c, lines 134-135
> > <https://reviewboard.asterisk.org/r/2040/diff/3/?file=30349#file30349line134>
> >
> >     I'm actually curious why this is only available with --enable-dev-mode only?
> >     
> >     Something like 'sip set debug on' does not depend on this.

Um, dunno. Previously some of the debugging was generally available, more detail required dev mode and enabling SKINNY_DEV_MODE in menuconfig.

Speculation only, but skinny debugging is different to SIP debugging (i think). SIP basically dumps packets (which is probably on a small bit of code), whereas skinny uses lots of strings and interrogates the various chan_skinny and ast_chan structures). Probably nice to be able to remove it if not needed.


- wedhorn


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2040/#review6705
-----------------------------------------------------------


On July 17, 2012, 6:04 p.m., wedhorn wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2040/
> -----------------------------------------------------------
> 
> (Updated July 17, 2012, 6:04 p.m.)
> 
> 
> Review request for Asterisk Developers and Matt Jordan.
> 
> 
> Summary
> -------
> 
> Rewrite of skinny debugging.
> 
> Debugging messages and associated controls only compiled in if configured with --enable-dev-mode
> 
> Debug messages provide more detail (including thread id) and are grouped so the user/dev can limit the type of messages displayed.
> 
> Functionally no real change to chan_skinny.
> 
> While the diff is fairly large, there are basically 3 components,
>  - definition of SKINNY_DEBUG at lines 134-152
>  - control functions at lines 3238-3374
>  - numerous uses of SKINNY_DEBUG throughout
> 
> 
> Diffs
> -----
> 
>   trunk/build_tools/cflags-devmode.xml 369904 
>   trunk/channels/chan_skinny.c 369904 
> 
> Diff: https://reviewboard.asterisk.org/r/2040/diff
> 
> 
> Testing
> -------
> 
> Been running for a while with --enable-dev-mode. Compiled and tested basic functionality without --enable-dev-mode.
> 
> 
> Thanks,
> 
> wedhorn
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120717/43af50ae/attachment-0001.htm>