[asterisk-dev] [Code Review]: Revise skinny debugging messages

[opticron]

> On July 13, 2012, 11:38 a.m., opticron wrote:
> > It appears that SKINNY_DEBUG is only used for ast_verb calls.  Consider refactoring to fit that case.
> 
> wedhorn wrote:
>     Not sure how this would be refactored given the unknown number of arguments being supplied to ast_verb.

Variadic macros: http://gcc.gnu.org/onlinedocs/cpp/Variadic-Macros.html
I'd also wrap the code inside the macro in a do{...}while(0) without the trailing ';' so that the ';' is required at the end of the macro (preferred method of making macros look like normal statements in Asterisk land).


- opticron


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2040/#review6681
-----------------------------------------------------------


On July 16, 2012, 9 p.m., wedhorn wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2040/
> -----------------------------------------------------------
> 
> (Updated July 16, 2012, 9 p.m.)
> 
> 
> Review request for Asterisk Developers and Matt Jordan.
> 
> 
> Summary
> -------
> 
> Rewrite of skinny debugging.
> 
> Debugging messages and associated controls only compiled in if configured with --enable-dev-mode
> 
> Debug messages provide more detail (including thread id) and are grouped so the user/dev can limit the type of messages displayed.
> 
> Functionally no real change to chan_skinny.
> 
> While the diff is fairly large, there are basically 3 components,
>  - definition of SKINNY_DEBUG at lines 134-152
>  - control functions at lines 3238-3374
>  - numerous uses of SKINNY_DEBUG throughout
> 
> 
> Diffs
> -----
> 
>   trunk/channels/chan_skinny.c 369904 
>   trunk/build_tools/cflags-devmode.xml 369904 
> 
> Diff: https://reviewboard.asterisk.org/r/2040/diff
> 
> 
> Testing
> -------
> 
> Been running for a while with --enable-dev-mode. Compiled and tested basic functionality without --enable-dev-mode.
> 
> 
> Thanks,
> 
> wedhorn
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120717/f3de94c9/attachment.htm>