[asterisk-dev] [Code Review]: func_jitterbuffer tests

[Matt Jordan]

> On July 13, 2012, 10:45 a.m., opticron wrote:
> > /asterisk/trunk/tests/funcs/func_jitterbuffer/test-config.yaml, line 19
> > <https://reviewboard.asterisk.org/r/2021/diff/2/?file=30192#file30192line19>
> >
> >     No tags?

Nope :-)

Tags make sense when you have tests that exercise related functionality.  Groups of 'one' don't add any value - you can always run an individual test using the '-t' option.  What functionality does func_jitterbuffer belong with?  The closest I can think of is something along the lines of 'audio', but we don't have a set of 'audio' specific tests (yet).


- Matt


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2021/#review6679
-----------------------------------------------------------


On July 12, 2012, 1:30 p.m., Matt Jordan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2021/
> -----------------------------------------------------------
> 
> (Updated July 12, 2012, 1:30 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This adds a new test to the Asterisk Test Suite that covers the JITTERBUFFER function.  This includes tests for the following:
> 
> * JITTERBUFFER(type)=default
> * JITTERBUFFER(type)=max_size,resync,target_extra
> 
> The variants in each test are:
> 
> type => adaptive or fixed jitter buffers
> max_size => default, 1000, 2000
> target_extra => default, 10, 50
> resync => default, 2000, 500
> 
> For each test, the following are checked:
> 
> * The JITTERBUFFER function creates a jitter buffer with the specified properties
> * That voice are streamed properly through a jitter buffer.  This uses the Record application, allong with BackgroundDetect for the recorded voice files.
> 
> This patch also groups all function tests under a new folder, "funcs"
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/funcs/func_jitterbuffer/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/funcs/func_jitterbuffer/configs/ast1/sip.conf PRE-CREATION 
>   /asterisk/trunk/tests/funcs/func_jitterbuffer/run-test PRE-CREATION 
>   /asterisk/trunk/tests/funcs/func_jitterbuffer/talking.ulaw UNKNOWN 
>   /asterisk/trunk/tests/funcs/func_jitterbuffer/test-config.yaml PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/2021/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Matt
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120713/f4f4feba/attachment.htm>