[asterisk-dev] [Code Review] code cleanup of sip.conf outboundproxy parsing

wdoekes reviewboard at asterisk.org
Thu Jul 12 14:19:34 CDT 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2034/
-----------------------------------------------------------

Review request for Asterisk Developers.


Summary
-------

Normally I'd put this in trunk, but it does contain an actual bugfix:


Index: channels/chan_sip.c
===================================================================
--- channels/chan_sip.c	(revision 369992)
+++ channels/chan_sip.c	(working copy)
@@ -27607,7 +27607,7 @@
 
 				if (ast_strlen_zero(proxyname)) {
 					ast_log(LOG_WARNING, "you must specify a name for the outboundproxy on line %d of sip.conf\n", v->lineno);
-					sip_cfg.outboundproxy.name[0] = '\0';
+					peer->outboundproxy->name[0] = '\0';
 					continue;
 				}


Diffs
-----

  /branches/1.8/channels/chan_sip.c 369992 

Diff: https://reviewboard.asterisk.org/r/2034/diff


Testing
-------

It compiles.


Thanks,

wdoekes

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120712/745d25a9/attachment.htm>


More information about the asterisk-dev mailing list