[asterisk-dev] [Code Review] func_jitterbuffer tests

Matt Jordan reviewboard at asterisk.org
Thu Jul 12 13:29:49 CDT 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2021/
-----------------------------------------------------------

(Updated July 12, 2012, 1:29 p.m.)


Review request for Asterisk Developers.


Changes
-------

Remove DTMF capabilities from func_jitterbuffer test.  As a result, with a test event added to func_jitterbuffer, this test can now be run against Asterisk 10.


Summary
-------

This adds a new test to the Asterisk Test Suite that covers the JITTERBUFFER function.  This includes tests for the following:

* JITTERBUFFER(type)=default
* JITTERBUFFER(type)=default,frame_type
* JITTERBUFFER(type)=max_size,resync,target_extra,frame_type
* Two jitter buffers using JITTERBUFFER(type)=max_size,resync,target_extra - one for dtmf and one for voice

The variants in each test are:

type => adaptive or fixed jitter buffers
frame_type => voice or dtmf
max_size => default, 1000, 2000
target_extra => default, 10, 50
resync => default, 2000, 500

For each test, the following are checked:

* The JITTERBUFFER function creates a jitter buffer with the specified properties
* If the function creates a DTMF jitter buffer, that the RTP layer allows out of order DTMF through its stack, deferring the handling to the jitter buffer
* That voice/dtmf are streamed properly through a jitter buffer.  This uses a combination of the Read/Record applications, allong with BackgroundDetect for the recorded voice files.

This patch also groups all function tests under a new folder, "funcs"


Diffs (updated)
-----

  /asterisk/trunk/tests/funcs/func_jitterbuffer/configs/ast1/extensions.conf PRE-CREATION 
  /asterisk/trunk/tests/funcs/func_jitterbuffer/configs/ast1/sip.conf PRE-CREATION 
  /asterisk/trunk/tests/funcs/func_jitterbuffer/run-test PRE-CREATION 
  /asterisk/trunk/tests/funcs/func_jitterbuffer/talking.ulaw UNKNOWN 
  /asterisk/trunk/tests/funcs/func_jitterbuffer/test-config.yaml PRE-CREATION 

Diff: https://reviewboard.asterisk.org/r/2021/diff


Testing
-------


Thanks,

Matt

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120712/3f887249/attachment.htm>


More information about the asterisk-dev mailing list