[asterisk-dev] [Code Review]: Turn HANGUPCAUSE into a function and add cause translations

[opticron]

> On July 11, 2012, 1:30 a.m., Tilghman Lesher wrote:
> > trunk/include/asterisk/channel.h, lines 3828-3829
> > <https://reviewboard.asterisk.org/r/2025/diff/3/?file=29994#file29994line3828>
> >
> >     The idea behind channel opaquification was to hide the implementation for things stored within the channel, not to create accessor functions for retrieving the internals.  I think these APIs need to be refactored in a manner such that the internals of how the channel stores dialed causes could be changed without changing everything that accesses it.

I have pushed the majority of the implemenation into channel_internal_api.c and exposed four primitives: add, find, channels (for the list), and clear.


- opticron


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2025/#review6660
-----------------------------------------------------------


On July 10, 2012, 7:36 p.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2025/
> -----------------------------------------------------------
> 
> (Updated July 10, 2012, 7:36 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This introduces two new functions and an application: one function to access the list of channels that have provided technology-specific cause information, one function to access the cause information itself, and a new application to clear that cause information.
> 
> This also introduces storage of and access to the per-channel translated Asterisk cause information.
> 
> 
> This addresses bug SWP-4739.
>     https://issues.asterisk.org/jira/browse/SWP-4739
> 
> 
> Diffs
> -----
> 
>   trunk/channels/chan_dahdi.c 369871 
>   trunk/channels/chan_iax2.c 369871 
>   trunk/channels/chan_sip.c 369900 
>   trunk/channels/sig_analog.c 369871 
>   trunk/channels/sig_pri.c 369871 
>   trunk/channels/sig_ss7.c 369871 
>   trunk/funcs/func_hangupcause.c PRE-CREATION 
>   trunk/include/asterisk/channel.h 369871 
>   trunk/include/asterisk/frame.h 369871 
>   trunk/main/channel.c 369871 
>   trunk/main/channel_internal_api.c 369871 
>   trunk/main/rtp_engine.c 369871 
> 
> Diff: https://reviewboard.asterisk.org/r/2025/diff
> 
> 
> Testing
> -------
> 
> Modified the current tests in the testsuite to use this new interface and they continued passing as expected.
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120711/a894e718/attachment-0001.htm>