[asterisk-dev] [Code Review] WebSocket SIP Support

[Joshua Colp]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2008/
-----------------------------------------------------------

(Updated July 11, 2012, 7:12 a.m.)


Review request for Asterisk Developers.


Changes
-------

Fixed issue with rejection of offer when AVPF is not enabled.


Summary
-------

These changes add WebSocket transport support to chan_sip and fix some minor issues uncovered in the stack when used with WebSocket as a transport.


Diffs (updated)
-----

  /trunk/channels/chan_sip.c 369847 
  /trunk/channels/sip/include/sip.h 369836 
  /trunk/channels/sip/sdp_crypto.c 369836 
  /trunk/channels/sip/security_events.c 369836 
  /trunk/configs/sip.conf.sample 369836 
  /trunk/include/asterisk/http_websocket.h 369836 
  /trunk/res/res_http_websocket.c 369836 

Diff: https://reviewboard.asterisk.org/r/2008/diff


Testing
-------

Tested using sipml5 javascript SIP stack. Confirmed protocol traffic is correct, that connections are shutdown properly when they should be, that registration works, and that calling works.


Thanks,

Joshua

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120711/c54433f4/attachment-0001.htm>