[asterisk-dev] [Code Review]: SDP Media Attribute Test

[Joshua Colp]

> On July 10, 2012, 2:18 p.m., Paul Belanger wrote:
> > /asterisk/trunk/tests/channels/SIP/SDP_attribute_passthrough/configs/ast1/extensions.conf, line 4
> > <https://reviewboard.asterisk.org/r/2029/diff/1/?file=29967#file29967line4>
> >
> >     remove

Fixed.


> On July 10, 2012, 2:18 p.m., Paul Belanger wrote:
> > /asterisk/trunk/tests/channels/SIP/SDP_attribute_passthrough/configs/ast1/sip.conf, line 1
> > <https://reviewboard.asterisk.org/r/2029/diff/1/?file=29968#file29968line1>
> >
> >     udpbindaddr=127.0.0.1

Added.


> On July 10, 2012, 2:18 p.m., Paul Belanger wrote:
> > /asterisk/trunk/tests/channels/SIP/SDP_attribute_passthrough/run-test, lines 88-92
> > <https://reviewboard.asterisk.org/r/2029/diff/1/?file=29969#file29969line88>
> >
> >     I believe you should be checking test.passed(), something about the TestRunner class.
> >     
> >     To be honest, I might be wrong since I have not tested out the new stuff.

Fixed.


> On July 10, 2012, 2:18 p.m., Paul Belanger wrote:
> > /asterisk/trunk/tests/channels/SIP/SDP_attribute_passthrough/test-config.yaml, line 9
> > <https://reviewboard.asterisk.org/r/2029/diff/1/?file=29974#file29974line9>
> >
> >     11.0.0?

Fixed.


> On July 10, 2012, 2:18 p.m., Paul Belanger wrote:
> > /asterisk/trunk/tests/channels/SIP/SDP_attribute_passthrough/sipp/phone_B_h263.xml, line 1
> > <https://reviewboard.asterisk.org/r/2029/diff/1/?file=29972#file29972line1>
> >
> >     IIRC, hard tabs break some versions of SIPp and had to convert them to spaces.

This is present in other files and seems to present no issue...


- Joshua


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2029/#review6648
-----------------------------------------------------------


On July 10, 2012, 2:30 p.m., Joshua Colp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2029/
> -----------------------------------------------------------
> 
> (Updated July 10, 2012, 2:30 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This test ensures that attribute information is transported through Asterisk.
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/channels/SIP/SDP_attribute_passthrough/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/SDP_attribute_passthrough/configs/ast1/sip.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/SDP_attribute_passthrough/run-test PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/SDP_attribute_passthrough/sipp/phone_A_h263.xml PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/SDP_attribute_passthrough/sipp/phone_A_h264.xml PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/SDP_attribute_passthrough/sipp/phone_A_speex.xml PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/SDP_attribute_passthrough/sipp/phone_B_h263.xml PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/SDP_attribute_passthrough/sipp/phone_B_h264.xml PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/SDP_attribute_passthrough/sipp/phone_B_speex.xml PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/SDP_attribute_passthrough/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/tests.yaml 3307 
> 
> Diff: https://reviewboard.asterisk.org/r/2029/diff
> 
> 
> Testing
> -------
> 
> Ran it, checked to make sure it worked okay. Tweaked test to fail and made sure it failed as expected.
> 
> 
> Thanks,
> 
> Joshua
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120710/a1576f04/attachment-0001.htm>