[asterisk-dev] [Code Review] Fix ExtenSpy on trunk.

rmudgett reviewboard at asterisk.org
Tue Jan 31 10:27:48 CST 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1702/
-----------------------------------------------------------

Review request for Asterisk Developers and Terry Wilson.


Summary
-------

When ast_channel name was opaquified, the channel search functions did not get converted correctly.

As a result ExtenSpy which uses a channel iterator search by exten at context can never find anything.

This patch fixes ExtenSpy and simplifies the channel search functions.

I also updated the doxygen documentation for the search functions in channel.h.


Diffs
-----

  /trunk/include/asterisk/channel.h 353453 
  /trunk/main/channel.c 353453 

Diff: https://reviewboard.asterisk.org/r/1702/diff


Testing
-------

Used ExtenSpy to test ast_channel_iterator_by_exten_new() which now works.

Used ChanSpy to test ast_channel_iterator_by_name_new() which still works.

Used CLI "channel request hangup D<tab> to test ast_channel_get_by_name_prefix() and executed the command to test ast_channel_get_by_name().


Thanks,

rmudgett

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120131/be9f45d0/attachment.htm>


More information about the asterisk-dev mailing list