[asterisk-dev] [Code Review] Allow res_calendar to be unloaded

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1657/#review5361
-----------------------------------------------------------

Ship it!


Good to go!

- Mark


On Jan. 30, 2012, 6:40 p.m., Terry Wilson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1657/
> -----------------------------------------------------------
> 
> (Updated Jan. 30, 2012, 6:40 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> I have seen res_calendar modules contribute to issues with core stop gracefully in part because res_calendar doesn't really unload or take care of the refresh thread that it spawns. There have been some non-calendar-related improvements that make the crash that was happening go away, but it is still very ugly for the module to not clean up after itself. This patch makes res_calendar unloadable and unloads the dependent calendar modules during its unload. 
> 
> The issue is only tangentially related to ASTERISK-16744, but it is what prompted me to go ahead and write the patch. Reloads are still handled through the main res_calendar module.
> 
> 
> This addresses bug ASTERISK-16744.
>     https://issues.asterisk.org/jira/browse/ASTERISK-16744
> 
> 
> Diffs
> -----
> 
>   /trunk/res/res_calendar.c 353417 
> 
> Diff: https://reviewboard.asterisk.org/r/1657/diff
> 
> 
> Testing
> -------
> 
> module unload res_calendar.so works, and the calendar tech modules are also unloaded. Loading the res_calendar module then a tech module creates the proper calendar entries from the config.
> 
> 
> Thanks,
> 
> Terry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120131/60f3b08d/attachment.htm>