[asterisk-dev] [Code Review] Fix occasionally incorrectly delayed call-file execution.

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1688/#review5355
-----------------------------------------------------------

Ship it!


This looks like the way to go.

- Mark


On Jan. 26, 2012, 11:25 a.m., rmudgett wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1688/
> -----------------------------------------------------------
> 
> (Updated Jan. 26, 2012, 11:25 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Call-files are sometimes delayed incorrectly.
> 
> This is actually a regression that has been in the code since 2007-07-11 (-r74704).  That code restructuring to reduce code indention, incorrectly inverted a test to determine if the spool directory needed to be rescanned.
> 
> Most of the changes to scan_thread() are coding guidelines fixes.
> 
> 
> This addresses bug ASTERISK-19081.
>     https://issues.asterisk.org/jira/browse/ASTERISK-19081
> 
> 
> Diffs
> -----
> 
>   /branches/1.8/pbx/pbx_spool.c 352754 
> 
> Diff: https://reviewboard.asterisk.org/r/1688/diff
> 
> 
> Testing
> -------
> 
> It compiles and I saw that the test was incorrectly inverted during a restructuring.
> 
> 
> Thanks,
> 
> rmudgett
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120130/37a630a4/attachment.htm>